NFT trades backwards compatibility #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xRobin
added
dune team
0xRobin
added
the
ready-for-review
jeff-dude
pushed a commit
that referenced
this pull request
May 17, 2023
* Restructure Cryptopunks to new NFT trades setup (#3286) * cryptopunks restructuring * add to trades_beta * fix join logic * fix call reference * fix bid pricing * fix bid buyer * syntax * fix * allow 0.1% error and fix seed value * Restructure Sudoswap to new NFT trades setup (#3329) * sudoswap restructuring * syntax fix * add seed test * Restructure collectionswap to new NFT trades setup (#3330) * restructure collectionswap * syntax fix * bugfix * use price_raw * add test seed * check-seed * Restructure looksrare to new NFT trades setup (#3332) * restructure looksrare * bugfix * bugfix * bugfix * add seed tests * fix seed * seed schema * cleanup * lr seed schema * NFT trades backwards compatibility layer (#3350) * compatibility layer * typo * test passes with no results * fix setup * fix * add fee percentages * nest test * move from string to varchar * allow the ignore of 1 punk sale in the rowcount test * allow the ignore of 1 punk sale in the rowcount test * allow the ignore of 1 punk sale in the rowcount test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a compatibility layer to later merge the newly restructured nft models to the existing nft.events model.