-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize labels/addresses/ migration #3809
Finalize labels/addresses/ migration #3809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This static file is too large.
https://github.com/duneanalytics/spellbook/actions/runs/5608297460/jobs/10260477632?pr=3809#step:12:21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if we just delete this file too, then essentially this PR does nothing but delete files
then, later, when doing the final labels roll-up spells, we could remove the refs to airdrop(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MSilb7 ,
since this static file is too large (>30 MB), do you think we can remove this file from spellbook and use csv upload?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since MSilb7 will upload airdrop_optimism_addresses_1
and airdrop_optimism_addresses_2
through csv, I am removing this file now.
i continued to remove files in the lineage here, both legacy and non-legacy. this should fail on check tags step due to |
@Hosuke what's the status here? still blocked for now? |
This PR will be unblocked when |
I think I can finalize all the rest of labels spells in this PR, which including:
|
I will try to use sources mentioned here for labels_airdrops #4436 (reply in thread) :
|
- name: op_airdrop2_addresses_detailed_list | ||
- name: op_airdrop_3_addresses_detailed_list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky for op_airdrop_3_addresses_detailed_list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @MSilb7
airdrop 3 has a different naming standard, it appears, with an extra _
in there
i won't consider a blocker here, but if you ever fix, make sure to update sources file and all source usage in models downstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niiice, more good progress here. thanks as always
Migrated spells in this PR: