Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/oracle addresses #4053

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Feature/oracle addresses #4053

merged 6 commits into from
Aug 22, 2023

Conversation

AnonJon
Copy link
Contributor

@AnonJon AnonJon commented Aug 11, 2023

Add new networks

  • arbitrum
  • avalanche_c
  • ethereum
  • fantom
  • gnosis

Add all the current feeds on each network for oracle addresses.

@dune-eng
Copy link

Workflow run id 5837741430 approved.

@dune-eng
Copy link

Workflow run id 5837741448 approved.

@dune-eng
Copy link

Workflow run id 5837917187 approved.

@dune-eng
Copy link

Workflow run id 5837917307 approved.

@dune-eng
Copy link

Workflow run id 5838047030 approved.

@dune-eng
Copy link

Workflow run id 5838047097 approved.

@dune-eng
Copy link

Workflow run id 5838124796 approved.

@dune-eng
Copy link

Workflow run id 5838125002 approved.

@dune-eng
Copy link

Workflow run id 5838209412 approved.

@dune-eng
Copy link

Workflow run id 5838209490 approved.

@dune-eng
Copy link

Workflow run id 5838283905 approved.

@dune-eng
Copy link

Workflow run id 5838283964 approved.

@dune-eng
Copy link

Workflow run id 5838399081 approved.

@dune-eng
Copy link

Workflow run id 5838399116 approved.

@dune-eng
Copy link

Workflow run id 5838520346 approved.

@dune-eng
Copy link

Workflow run id 5838520497 approved.

@dune-eng
Copy link

Workflow run id 5838671527 approved.

@dune-eng
Copy link

Workflow run id 5838671447 approved.

@dune-eng
Copy link

Workflow run id 5838747377 approved.

@dune-eng
Copy link

Workflow run id 5838747463 approved.

@dune-eng
Copy link

Workflow run id 5838838034 approved.

@dune-eng
Copy link

Workflow run id 5838838057 approved.

@dune-eng
Copy link

Workflow run id 5838922252 approved.

@dune-eng
Copy link

Workflow run id 5838922385 approved.

@dune-eng
Copy link

Workflow run id 5856996670 approved.

@dune-eng
Copy link

Workflow run id 5856996795 approved.

@dune-eng
Copy link

Workflow run id 5869512396 approved.

@dune-eng
Copy link

Workflow run id 5869512083 approved.

@dune-eng
Copy link

Workflow run id 5869734999 approved.

@dune-eng
Copy link

Workflow run id 5869734813 approved.

@dune-eng
Copy link

Workflow run id 5913775811 approved.

@AnonJon
Copy link
Contributor Author

AnonJon commented Aug 19, 2023

recheck

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

2 out of 3 committers have signed the CLA.
✅ @anon-r-7
✅ @AnonJon
❌ @jonathan gregis
jonathan gregis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@AnonJon AnonJon force-pushed the feature/oracle-addresses branch from 067ad3e to 83732f7 Compare August 19, 2023 22:28
@dune-eng
Copy link

Workflow run id 5913840321 approved.

@dune-eng
Copy link

Workflow run id 5913840339 approved.

@Hosuke
Copy link
Collaborator

Hosuke commented Aug 20, 2023

Hi @Hosuke, by dummy models are you referring to adding legacy models for feeds and feeds_hourly for all new networks?

Yes, if the spell do not have a corresponding legacy model, then you can add a dummy model for the spell.

@dune-eng
Copy link

Workflow run id 5919376425 approved.

@dune-eng
Copy link

Workflow run id 5919376460 approved.

@AnonJon AnonJon requested a review from Hosuke August 20, 2023 20:36
Hosuke
Hosuke approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @AnonJon

  • Partition by block_month ✅
  • Dummy legacy models added for new spells ✅

anon-r-7 and others added 6 commits August 21, 2023 21:24
@anon-r-7 @AnonJon
Add Chainlink OCR to arbitrum, avalanche_c, bnb, ethereum, fantom, gn…
b0deeb6 
…osis, optimism, and polygon

Generate OCR Operator Meta
Add incremental tables to Chainlink OCR and add a README
Alphabetize OCR Operator Meta
General OCR Cleanup
Polish Chainlink OCR Model
@anon-r-7 @AnonJon
Add incremental table tests
59dfc13
@AnonJon
add new networks to chainlink feeds, add all current feeds per network
326b691
@AnonJon
Trigger CI
6ce5271
@AnonJon
Trigger CI
be606a5
@AnonJon
add dummy models for new networks
1ac11f0
@AnonJon AnonJon force-pushed the feature/oracle-addresses branch from 0eca0b4 to 1ac11f0 Compare August 21, 2023 19:24
@dune-eng
Copy link

Workflow run id 5930596616 approved.

@dune-eng
Copy link

Workflow run id 5930596627 approved.

@AnonJon
Copy link
Contributor Author

AnonJon commented Aug 21, 2023

@Hosuke just rebased. Feel free to merge when you are able.

@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-final-review labels Aug 22, 2023
jeff-dude
jeff-dude approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@jeff-dude jeff-dude merged commit 337f50b into duneanalytics:main Aug 22, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Aug 22, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Dune Contributor:

GitPOAP: 2023 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
@AnonJon AnonJon deleted the feature/oracle-addresses branch August 23, 2023 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hosuke Hosuke Hosuke approved these changes

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
in review Assignee is currently reviewing the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnonJon @dune-eng @Hosuke @jeff-dude @anon-r-7