NFT transfers refactor #4072
Merged
NFT transfers refactor #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-dude
reviewed
Aug 14, 2023
jeff-dude
reviewed
Aug 14, 2023
jeff-dude
reviewed
Aug 14, 2023
|
failures on CI here are just due to your branches being out of date with main, rebasing should fix |
aalan3
force-pushed
the
nft-transfers-performance
branch
from
7722099 to
802ef08
Compare
This reverts commit 09e374d.
Keep it for backward compatibility
|
|
jeff-dude
reviewed
Aug 22, 2023
jeff-dude
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #4050.
I've removed theI updatedunique_transfer_idunique_transfer_idas this column is quite big and can impact performance of the run. I also removed the anti join, trino should be able to handle this on it's own duringmerge into.