Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeroex - refactor eth models [FOR REVIEW] #4075

Merged
merged 96 commits into from
Sep 13, 2023
Merged

Conversation

RantumBits
Copy link
Contributor

refactor ethereum models

RantumBits and others added 30 commits June 1, 2021 14:07
@dune-eng
Copy link

dune-eng commented Sep 6, 2023

Workflow run id 6102292694 approved.

@dune-eng
Copy link

dune-eng commented Sep 6, 2023

Workflow run id 6102812229 approved.

@dune-eng
Copy link

dune-eng commented Sep 6, 2023

Workflow run id 6102812433 approved.

@dune-eng
Copy link

dune-eng commented Sep 6, 2023

Workflow run id 6103022707 approved.

@dune-eng
Copy link

dune-eng commented Sep 6, 2023

Workflow run id 6103022939 approved.

@dune-eng
Copy link

dune-eng commented Sep 6, 2023

Workflow run id 6103080658 approved.

@dune-eng
Copy link

dune-eng commented Sep 6, 2023

Workflow run id 6103080723 approved.

@dune-eng
Copy link

dune-eng commented Sep 7, 2023

Workflow run id 6111961095 approved.

@dune-eng
Copy link

dune-eng commented Sep 7, 2023

Workflow run id 6111961461 approved.

@dune-eng
Copy link

dune-eng commented Sep 7, 2023

Workflow run id 6112318757 approved.

@dune-eng
Copy link

dune-eng commented Sep 7, 2023

Workflow run id 6112318854 approved.

@RantumBits
Copy link
Contributor Author

requested changes are complete @jeff-dude

@dune-eng
Copy link

Workflow run id 6165044412 approved.

@dune-eng
Copy link

Workflow run id 6165044368 approved.

@dune-eng
Copy link

Workflow run id 6165046141 approved.

@dune-eng
Copy link

Workflow run id 6165046242 approved.

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

do you plan to continue on all blockchains?
i've started this PR to migrate the sector level spell, which has a dependency on all 0x spells to be migrated first

@jeff-dude
Copy link
Member

thank you!

do you plan to continue on all blockchains? i've started this PR to migrate the sector level spell, which has a dependency on all 0x spells to be migrated first

curious if we should help you continue on other blockchains, or if you have already started

@jeff-dude jeff-dude merged commit 9f6776a into duneanalytics:main Sep 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
@RantumBits RantumBits deleted the eth branch August 9, 2024 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in review Assignee is currently reviewing the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants