Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPE-4 Migrate & rework dex.sandwiches #4315

Merged
merged 50 commits into from
Sep 27, 2023

Conversation

hildobby
Copy link
Collaborator

Thank you for contributing to Spellbook!

Please refer to the top of the readme in the root of Spellbook to learn how to contribute to Spellbook on DuneSQL.

@hildobby hildobby added WIP work in progress dbt: dex covers the DEX dbt subproject labels Sep 12, 2023
@hildobby
Copy link
Collaborator Author

Huh "Table 'hive.dex.trades' does not exist"? What did I do wrong here @jeff-dude?

@hildobby hildobby added question Further information is requested and removed WIP work in progress labels Sep 12, 2023
@Hosuke
Copy link
Collaborator

Hosuke commented Sep 12, 2023

Huh "Table 'hive.dex.trades' does not exist"? What did I do wrong here @jeff-dude?

This means dex.trades is not migrated yet(The spell does not have the dunesql tag).

We may use dex.trades_migration_beta instead for current testing.

@hildobby
Copy link
Collaborator Author

trades_migration_beta

Alright thanks, I'll try out using dex.trades_migration_beta instead then

@hildobby hildobby added WIP work in progress and removed question Further information is requested labels Sep 13, 2023
@jeff-dude
Copy link
Member

trades_migration_beta

Alright thanks, I'll try out using dex.trades_migration_beta instead then

well, good news is dex.trades is now live on dunesql 🙌

less good news, you'll have to change code back 🤷‍♂️

@jeff-dude jeff-dude changed the title Migrate & rework dex.sandwiches SPE-4 Migrate & rework dex.sandwiches Sep 13, 2023
@hildobby
Copy link
Collaborator Author

trades_migration_beta

Alright thanks, I'll try out using dex.trades_migration_beta instead then

well, good news is dex.trades is now live on dunesql 🙌

less good news, you'll have to change code back 🤷‍♂️

Damn that was quick wtf, I swear the migration started barely a week ago

@0xRobin
Copy link
Collaborator

0xRobin commented Sep 23, 2023

@hildobby I was actually able to run this successfully locally

@couralex6 curious what model you were able to run locally, as there seems to be still some issues in the macro that should make these models fail to run. 🤔

@couralex6
Copy link
Contributor

@hildobby I was actually able to run this successfully locally

@couralex6 curious what model you were able to run locally, as there seems to be still some issues in the macro that should make these models fail to run. 🤔

Oops you're right I was running on old version of the branch

@jeff-dude jeff-dude removed the question Further information is requested label Sep 25, 2023
@hildobby hildobby added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Sep 27, 2023
@Hosuke
Copy link
Collaborator

Hosuke commented Sep 27, 2023

Currently only sandwiches records on ethereum is available:
https://dune.com/queries/3056258

@jeff-dude jeff-dude self-assigned this Sep 27, 2023
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Sep 27, 2023
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful PR here! love to see the use of macros becoming the norm, it makes everyone's lives easier.

thanks again for all the help in migration 🤝

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Sep 27, 2023
@jeff-dude jeff-dude merged commit c4fc394 into duneanalytics:main Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants