Add Mauve - ready for review

[ra-phael]

This PR adds new spells for Mauve (https://www.mauve.org/).

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[dune-eng]

Workflow run id 6251675902 approved.

[dune-eng]

Workflow run id 6251675800 approved.

[ra-phael]

I have read the CLA Document and I hereby sign the CLA

[dune-eng]

Workflow run id 6251849825 approved.

[dune-eng]

Workflow run id 6251849750 approved.

[dune-eng]

Workflow run id 6259377353 approved.

[dune-eng]

Workflow run id 6259377457 approved.

[dune-eng]

Workflow run id 6259730234 approved.

[dune-eng]

Workflow run id 6259730318 approved.

[dune-eng]

Workflow run id 6259988845 approved.

[dune-eng]

Workflow run id 6259988687 approved.

[dune-eng]

Workflow run id 6260093100 approved.

[dune-eng]

Workflow run id 6260093242 approved.

[dune-eng]

Workflow run id 6260762369 approved.

[dune-eng]

Workflow run id 6262059304 approved.

[dune-eng]

Workflow run id 6262441327 approved.

[dune-eng]

Workflow run id 6262440961 approved.

[ra-phael]

I added the LsETH token in models/tokens/ethereum/tokens_ethereum_erc20.sql but mauve_ethereum_trades still have empty columns for this token when it is involved in a trade...

What am I missing? @jeff-dude

Sorry I'm a Dune newbie, this is like my first day in the school of Blockchain analytics and Wizardry. 😆

[dune-eng]

Workflow run id 6274269428 approved.

[dune-eng]

Workflow run id 6274269522 approved.

[dune-eng]

Workflow run id 6296976608 approved.

[dune-eng]

Workflow run id 6296976733 approved.

[jeff-dude]

I added the LsETH token in models/tokens/ethereum/tokens_ethereum_erc20.sql but mauve_ethereum_trades still have empty columns for this token when it is involved in a trade...

What am I missing? @jeff-dude

Sorry I'm a Dune newbie, this is like my first day in the school of Blockchain analytics and Wizardry. 😆

no need to apologize -- welcome to spellbook and thank you for contributing 🪄

i think i see the issue here and it's not anything you've done wrong. in our PR CI test actions, we only run models which are directly modified in that specific PR. if a model is referenced and not in the PR, it will read from prod instead. in this instance, you modify the tokens_ethereum_erc20 spell, but the tokens_erc20 spell is not included, which combines all blockchains into one. then in your new dex spell, you join to tokens_erc20, which will then read from prod instead (i.e. no new token).

your best bet for a quick workaround is to modify the tokens_erc20 spell to be included here. it could be a simple new line addition, remove an empty line, etc etc.

[ra-phael]

Got it, thank you for the explanation!

[jeff-dude]

Got it, thank you for the explanation!

are you good with letting this ride then, and pushing to prod? there it will follow proper dependencies & tokens would flow through.

[ra-phael]

Yes, pushing to prod sounds good to me.

[dune-eng]

Workflow run id 6327781771 approved.

[dune-eng]

Workflow run id 6327781976 approved.

[jeff-dude]

sounds good -- let's get this queued up for merge!

thanks again for the contribution

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Dune Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.