Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrum base trades #4879

Merged
merged 71 commits into from
Jan 5, 2024
Merged

Arbitrum base trades #4879

merged 71 commits into from
Jan 5, 2024

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Nov 27, 2023

  • arbitrum base_trades
  • missing eth marketplaces (liquidifty and trove)

0xRobin and others added 30 commits October 24, 2023 13:42
@0xRobin
revamp NFT sector to new spell design guidelines
e7727ac
@0xRobin
wip
778ae37
@0xRobin
fix compile
668dc3b
@0xRobin
Merge branch 'main' into nft-sector-design
48e947b
@0xRobin
remove aliases
077c12b
@0xRobin
bugfix
781dce1
@0xRobin
fix timestamp cast
66f51a4
@0xRobin
fix for loops
8d48ccf
@0xRobin
syntax
3eaf78b
@0xRobin
re-trigger CI
9566baa
@0xRobin
try incremental idk
1919872
@0xRobin
spent 4 hours looking for 2 missing brackets, great
f1585a9
@0xRobin
variable had wrong name..
c695037
@0xRobin
temp disable aggregator marks
63128a7
@0xRobin
Merge branch 'main' into nft-sector-design
3867502
@0xRobin
correct unique_trade_id
b403065
@0xRobin
add version to liquidifty
e376c59
@0xRobin
trigger CI
50c422a
@0xRobin
seeds
fdb7256
@0xRobin
fix liquidifty v3
6a9e9af
@0xRobin
syntax
d4b24f2
@0xRobin
syntax
8e76d97
@0xRobin
trigger CI
d278ee4
@0xRobin
wip
ce6709f
@0xRobin
Merge branch 'main' into nft-sector-design
d553443
@0xRobin
32 bytes tx data marker
905bc48
@0xRobin
macro naming
3adbd37
@0xRobin
fix syntax
304b455
@0xRobin
remove stub matching
352ceb1
@0xRobin
Merge branch 'main' into nft-sector-design
cf293da
@0xRobin 0xRobin marked this pull request as ready for review December 19, 2023 14:51
@0xRobin 0xRobin added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 19, 2023
@jeff-dude jeff-dude self-assigned this Dec 22, 2023
@0xRobin 0xRobin force-pushed the arbitrum-base-trades branch from 1ab8789 to 96d144c Compare January 4, 2024 11:34
@jeff-dude jeff-dude added WIP work in progress and removed ready-for-review this PR development is complete, please review labels Jan 4, 2024
@0xRobin 0xRobin added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 4, 2024
@0xRobin 0xRobin requested a review from jeff-dude January 4, 2024 15:47
@0xRobin
Copy link
Collaborator Author

0xRobin commented Jan 4, 2024

@jeff-dude I'm indeed fixing the incremental_predicate whenever it catches my eye. Will do a full sweep through the NFT sector once all chains are migrated.

@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jan 5, 2024
jeff-dude
jeff-dude approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jan 5, 2024
@jeff-dude jeff-dude merged commit 00e61c0 into duneanalytics:main Jan 5, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
@0xRobin 0xRobin deleted the arbitrum-base-trades branch May 20, 2024 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: nft covers the NFT dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xRobin @jeff-dude