Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Contract Metadata Updates #4887

Merged
merged 33 commits into from
Dec 12, 2023

Conversation

MSilb7
Copy link
Contributor

@MSilb7 MSilb7 commented Nov 28, 2023

Storing static contracts metadata updates.

Ready to merge whenever, but I'll keep adding stuff until then.

@dune-eng
Copy link

Workflow run id 7013500135 approved.

@dune-eng
Copy link

Workflow run id 7013500195 approved.

@dune-eng
Copy link

Workflow run id 7013545427 approved.

@dune-eng
Copy link

Workflow run id 7013545462 approved.

@dune-eng
Copy link

Workflow run id 7013908492 approved.

@dune-eng
Copy link

Workflow run id 7013908494 approved.

@dune-eng
Copy link

Workflow run id 7019673633 approved.

@dune-eng
Copy link

Workflow run id 7019673629 approved.

@dune-eng
Copy link

Workflow run id 7019737594 approved.

@dune-eng
Copy link

Workflow run id 7019737436 approved.

@dune-eng
Copy link

Workflow run id 7019739637 approved.

@dune-eng
Copy link

Workflow run id 7019739869 approved.

@dune-eng
Copy link

Workflow run id 7020328517 approved.

@dune-eng
Copy link

Workflow run id 7020328701 approved.

@MSilb7 MSilb7 marked this pull request as ready for review November 28, 2023 14:56
@dune-eng
Copy link

Workflow run id 7020555830 approved.

@dune-eng
Copy link

Workflow run id 7020556044 approved.

@MSilb7 MSilb7 changed the title [DRAFT] Static Contract Metadata Updates Static Contract Metadata Updates Nov 28, 2023
@dune-eng
Copy link

dune-eng commented Dec 6, 2023

Workflow run id 7119250387 approved.

@dune-eng
Copy link

dune-eng commented Dec 6, 2023

Workflow run id 7119250540 approved.

@dune-eng
Copy link

dune-eng commented Dec 6, 2023

Workflow run id 7119291790 approved.

@dune-eng
Copy link

dune-eng commented Dec 6, 2023

Workflow run id 7119291788 approved.

@dune-eng
Copy link

dune-eng commented Dec 6, 2023

Workflow run id 7119668875 approved.

@dune-eng
Copy link

dune-eng commented Dec 6, 2023

Workflow run id 7119668995 approved.

@jeff-dude jeff-dude self-assigned this Dec 7, 2023
@jeff-dude jeff-dude added the in review Assignee is currently reviewing the PR label Dec 7, 2023
@jeff-dude
Copy link
Member

i don't understand what change is forcing all these seeds to run, v odd

@MSilb7
Copy link
Contributor Author

MSilb7 commented Dec 11, 2023

i don't understand what change is forcing all these seeds to run, v odd

I wonder if it's the tokens update? @jeff-dude

@dune-eng
Copy link

Workflow run id 7167933706 approved.

@dune-eng
Copy link

Workflow run id 7167933808 approved.

@dune-eng
Copy link

Workflow run id 7167947603 approved.

@dune-eng
Copy link

Workflow run id 7167964789 approved.

@@ -49,7 +49,7 @@ jobs:
[[ -z "$test" ]] && { echo "Success: All models have a custom schema"; exit 0; } || { echo "Found models without custom schema:"; echo "$test"; exit 1; }

- name: dbt seed
run: "dbt seed $PROFILE --select @state:modified --exclude tag:prod_exclude tag:remove --state ."
run: "dbt seed $PROFILE --select state:modified --exclude tag:prod_exclude tag:remove --state ."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the @ here runs any seed that is in a dbt lineage within context of PR, even if the specific model that calls the seed test isn't modified. removing it helps here, but we've also added for helping other PRs. i think rather than remove it, i'll look to fix the seed issue in another PR

@jeff-dude
Copy link
Member

fixed seed here #4975

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 🙏

plz see comments for context

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Dec 11, 2023
@jeff-dude jeff-dude merged commit ede7c91 into duneanalytics:main Dec 12, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants