-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Contract Metadata Updates #4887
Static Contract Metadata Updates #4887
Conversation
Workflow run id 7013500135 approved. |
Workflow run id 7013500195 approved. |
Workflow run id 7013545427 approved. |
Workflow run id 7013545462 approved. |
Workflow run id 7013908492 approved. |
Workflow run id 7013908494 approved. |
Workflow run id 7019673633 approved. |
Workflow run id 7019673629 approved. |
Workflow run id 7019737594 approved. |
Workflow run id 7019737436 approved. |
Workflow run id 7019739637 approved. |
Workflow run id 7019739869 approved. |
Workflow run id 7020328517 approved. |
Workflow run id 7020328701 approved. |
…spellbook into contracts-static-nov2023
Workflow run id 7020555830 approved. |
Workflow run id 7020556044 approved. |
Workflow run id 7119250387 approved. |
Workflow run id 7119250540 approved. |
Workflow run id 7119291790 approved. |
Workflow run id 7119291788 approved. |
Workflow run id 7119668875 approved. |
Workflow run id 7119668995 approved. |
i don't understand what change is forcing all these seeds to run, v odd |
I wonder if it's the tokens update? @jeff-dude |
Workflow run id 7167933706 approved. |
Workflow run id 7167933808 approved. |
Workflow run id 7167947603 approved. |
Workflow run id 7167964789 approved. |
.github/workflows/dbt_slim_ci.yml
Outdated
@@ -49,7 +49,7 @@ jobs: | |||
[[ -z "$test" ]] && { echo "Success: All models have a custom schema"; exit 0; } || { echo "Found models without custom schema:"; echo "$test"; exit 1; } | |||
|
|||
- name: dbt seed | |||
run: "dbt seed $PROFILE --select @state:modified --exclude tag:prod_exclude tag:remove --state ." | |||
run: "dbt seed $PROFILE --select state:modified --exclude tag:prod_exclude tag:remove --state ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the @
here runs any seed that is in a dbt lineage within context of PR, even if the specific model that calls the seed test isn't modified. removing it helps here, but we've also added for helping other PRs. i think rather than remove it, i'll look to fix the seed issue in another PR
fixed seed here #4975 |
This reverts commit 421671e.
…spellbook into contracts-static-nov2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed 🙏
plz see comments for context
Storing static contracts metadata updates.
Ready to merge whenever, but I'll keep adding stuff until then.