Added Optimism Unidex Dex #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow run id 7299479772 approved. |
jeff-dude
added
ready-for-review
|
Workflow run id 7318977286 approved. |
|
Workflow run id 7318977517 approved. |
Hosuke
approved these changes
Dec 26, 2023
Hosuke
added
ready-for-final-review
and removed
ready-for-review
jeff-dude
requested changes
Jan 2, 2024
| }} | ||
|
|
||
| {% set project_start_date = '2023-03-08' %} | ||
| {% set firebird_finance_optimism_evt_trade_tables = [ |
There was a problem hiding this comment.
Suggested change
| {% set firebird_finance_optimism_evt_trade_tables = [ | |
| {% set unidex_optimism_evt_trade_tables = [ |
| ] %} | ||
|
|
||
| with dexs as ( | ||
| {% for evt_trade_table in firebird_finance_optimism_evt_trade_tables %} |
There was a problem hiding this comment.
Suggested change
| {% for evt_trade_table in firebird_finance_optimism_evt_trade_tables %} | |
| {% for evt_trade_table in unidex_optimism_evt_trade_tables %} |
|
Workflow run id 7393566661 approved. |
|
Workflow run id 7393570119 approved. |
|
Workflow run id 7393570181 approved. |
|
Hello @jeff-dude, I have made the requested changes. Please let me know if anything else is required from my end. |
jeff-dude
approved these changes
Jan 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added trades data for unidex dex.