Added odos_v2 optimism dex #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow run id 7724597808 approved. |
|
Workflow run id 7724598041 approved. |
jeff-dude
requested changes
Jan 31, 2024
There was a problem hiding this comment.
thank you for adapting to the new sub-project approach quickly.
can you update odos version spells to use the universal unique key for dex_aggregator.trades lineage?
https://github.com/duneanalytics/spellbook/blob/main/models/dex/dex_aggregator_trades.sql#L9
jeff-dude
added
question
|
Workflow run id 7735983115 approved. |
|
Workflow run id 7735983214 approved. |
|
Workflow run id 7736288048 approved. |
|
Workflow run id 7736288094 approved. |
jeff-dude
requested changes
Feb 1, 2024
jeff-dude
added
WIP
|
Workflow run id 7751700228 approved. |
|
Workflow run id 7751700289 approved. |
|
Workflow run id 7751844869 approved. |
|
Workflow run id 7751844951 approved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added trade data for
odos_v2onoptimismaccording to the new updated code (tokens-sub-project).