Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zigzag_arbitrum_base_trades into dex.trades_beta #5279

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

Hosuke
Copy link
Collaborator

@Hosuke Hosuke commented Feb 2, 2024

Thank you for contributing to Spellbook!

Thank you for taking the time to submit code in Spellbook. A few things to consider:

  • If you are a first-time contributor, please sign the CLA by copy & pasting exactly what the bot mentions in PR comment
  • Refer to docs section below to answer questions
  • Dune team will review submitted PRs as soon as possible

Spellbook sub-projects

To prepare for Spellbook to scale in size, Dune team has started to pilot sub-projects:

  • For a quick overview, see the GH discussion on the topic
    • Please ask questions and continue the conversation there
  • The first spell lineage to move: tokens.erc20 and all upstream spells which help build it
    • Note: Please navigate to tokens root directory to find tokens objects

Spellbook contribution docs

The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each .md file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄

Example questions to be answered:

Please navigate through the docs directory to find as much info as you can.

Note: happy to take PRs to improve the docs, let us know 🤝

@Hosuke Hosuke added the WIP work in progress label Feb 2, 2024
@Hosuke Hosuke added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 2, 2024
@Hosuke Hosuke added the dbt: dex covers the DEX dbt subproject label Feb 2, 2024
@jeff-dude jeff-dude merged commit a1e5314 into duneanalytics:main Feb 2, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
@Hosuke Hosuke deleted the dex-beta-zigzag branch February 6, 2024 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-review this PR development is complete, please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants