ADDED BASO FINANCE (BASE) TO DEX.TRADES #5476
Conversation
|
Workflow run id 8099288496 approved. |
|
Workflow run id 8099288716 approved. |
|
Workflow run id 8100514502 approved. |
|
Workflow run id 8100514704 approved. |
| meta: | ||
| blockchain: base | ||
| sector: dex | ||
| project: baso_finance |
There was a problem hiding this comment.
Hi @sophie-analytics,
have you added baso_finance into dex.info?
https://github.com/duneanalytics/spellbook/blob/main/models/dex/dex_info.sql
Also please check for other similar dex.trades pr as well.
There was a problem hiding this comment.
@Hosuke DONE! I have added it now
Hosuke
added
in review
|
Workflow run id 8102088504 approved. |
|
Workflow run id 8102088479 approved. |
|
Workflow run id 8102311056 approved. |
|
Workflow run id 8102311260 approved. |
| - check_dex_base_trades_seed: | ||
| seed_file: ref('baso_finance_base_base_trades_seed') | ||
| filter: | ||
| version: 1 |
There was a problem hiding this comment.
The version seems unmatched to baso_finance_base.base_trades, please recheck.
(If the seed file only contains one version, we may remove the filter.)
There was a problem hiding this comment.
Yeah. It's just one version. I have removed the filter
|
Workflow run id 8112867742 approved. |
|
Workflow run id 8112867909 approved. |
| base,baso_finance,1,2024-02-29,0xffd4b1a0feccb552677f66dfad9c9513ab099e8861df3c9680a71403fbdc01a8,97,0xd9aaec86b65d86f6a7b5b1b0c42ffa531710b6ca,0x4200000000000000000000000000000000000006,11219567,20130916,5917311547268586 | ||
| base,baso_finance,1,2024-02-29,0x77b30ef875f23152d952956180bb110cf87c583c24d8922e605630503c8a9fa0,8,0x4200000000000000000000000000000000000006,0xd9aaec86b65d86f6a7b5b1b0c42ffa531710b6ca,11218505,3002100810131972,10328676 |
There was a problem hiding this comment.
The version you record here is 1, while in baso_finance_base.base_trades is 2.
https://github.com/duneanalytics/spellbook/pull/5476/files#diff-df7fe6ef229169722ae0a95c5982d333b6a90199dd992bc5a832131a9993d2b1R17
|
Hi @sophie-analytics, |
Hosuke
added
ready-for-final-review
and removed
in review
Thank you for contributing to Spellbook!
Thank you for taking the time to submit code in Spellbook. A few things to consider:
Spellbook sub-projects
To prepare for Spellbook to scale in size, Dune team has started to pilot sub-projects:
tokens.erc20and all upstream spells which help build itSpellbook contribution docs
The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each
.mdfile within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄Example questions to be answered:
Please navigate through the docs directory to find as much info as you can.
Note: happy to take PRs to improve the docs, let us know 🤝