Migrate cex_ethereum.flows to a sector spell with macros to easily add new chains #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hildobby
added
WIP
jeff-dude
reviewed
Mar 11, 2024
| FROM {{ ref('tokens_ethereum_transfers')}} t | ||
| INNER JOIN {{ ref('cex_ethereum_addresses')}} a ON a.address IN (t."from", t.to) | ||
| FROM {{transfers}} t | ||
| INNER JOIN {{addresses}} a ON a.address IN (t."from", t.to) |
There was a problem hiding this comment.
can you run a quick test on performance to see how runtime looks when you remove IN and do (a.address = t."from" or a.address = t.to)?
There was a problem hiding this comment.
old run for reference:
https://github.com/duneanalytics/spellbook/actions/runs/8178326082/job/22361994788
can compare when new is done
There was a problem hiding this comment.
okay, no real change. feel free to keep as-is or revert to your preference
There was a problem hiding this comment.
it's good as is, feel free to merge
jeff-dude
added
question
jeff-dude
approved these changes
Mar 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal here is to create this macro so i can easily add cex_{chain}.flows for all other evm chains afterwards @jeff-dude