Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll prices and tokens #5569

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Mar 12, 2024

Initial tokenset taken from https://scrollscan.com/tokens

@0xRobin 0xRobin added ready-for-review this PR development is complete, please review dune team created by dune team labels Mar 12, 2024
@0xRobin
Copy link
Collaborator Author

0xRobin commented Mar 12, 2024

coinpaprika doesn't have a scroll contract list yet (see https://api.coinpaprika.com/v1/contracts).
So failure in token-prices-test is expected

@0xRobin 0xRobin requested a review from jeff-dude March 12, 2024 09:55
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, thanks for the reminder link from coinpaprika api there

@jeff-dude jeff-dude merged commit 8bca233 into duneanalytics:main Mar 12, 2024
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@0xRobin 0xRobin deleted the scroll-tokens branch May 20, 2024 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dune team created by dune team ready-for-review this PR development is complete, please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants