Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook!
Thank you for taking the time to submit code in Spellbook. A few things to consider:
Best practices
To speed up your development process in PRs, keep these tips in mind:
readme
) and rundbt compile
target/
directory to copy/paste and run on Dune directly for initial query testingWHERE
filter for only ~7 days of history on large source tables, i.e.ethereum.transactions
Incremental model setup
COALESCE()
as needed on key column(s), otherwise the tests may fail on duplicates🪄 Use the built CI tables for testing 🪄
Once CI completes, you can query the CI tables and errors in dune when it finishes running.
run initial models
andtest initial models
, there will be a schema that looks like this:test_schema.git_dunesql_4da8bae_sudoswap_v2_base_pool_creations
Leverage these tables to perform QA testing on Dune query editor -- or even full test dashboards!
Spellbook contribution docs
The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each
.md
file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄Example questions to be answered:
Please navigate through the docs directory to find as much info as you can.
Note: happy to take PRs to improve the docs, let us know 🤝