-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add camelot pair fee rates spellbook #5846
feat: add camelot pair fee rates spellbook #5846
Conversation
Workflow run id 8868362688 approved. |
Workflow run id 8868362582 approved. |
Workflow run id 8868389985 approved. |
Workflow run id 8868390209 approved. |
Workflow run id 8868391866 approved. |
Workflow run id 8868391946 approved. |
Workflow run id 8868444968 approved. |
Workflow run id 8868445164 approved. |
Workflow run id 8869537619 approved. |
Workflow run id 8869537641 approved. |
Workflow run id 8869651739 approved. |
Workflow run id 8869651810 approved. |
Workflow run id 8869725013 approved. |
Workflow run id 8869725059 approved. |
Workflow run id 8869862292 approved. |
Workflow run id 8869862371 approved. |
Workflow run id 8869962623 approved. |
Workflow run id 8869962679 approved. |
Workflow run id 8929303512 approved. |
Workflow run id 8929339607 approved. |
Workflow run id 8929339778 approved. |
Workflow run id 8929399358 approved. |
Workflow run id 8929399510 approved. |
51ef6a6
to
209bcef
Compare
Workflow run id 8929443037 approved. |
Workflow run id 8929443371 approved. |
Workflow run id 8929502868 approved. |
Workflow run id 8929503042 approved. |
This reverts commit ad80d3f.
Workflow run id 8929554074 approved. |
Workflow run id 8929554219 approved. |
Workflow run id 8934862933 approved. |
Workflow run id 8934863151 approved. |
Workflow run id 8934913155 approved. |
Workflow run id 8934913380 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff here 🔥
let's get it merged
The Camelot DEX on Arbitrum has a dynamic fee rate model, both for v2 and v3 architecture:
The Camelot ⚔️🤴🏼 Dashboard has been broken since 2 months, because the query logic that determines the latest fee rate for each swap is super inefficient, which leads to >30min execution runtimes, so the query runs fail.
I discussed potential solutions with @0xBoxer and the Camelot team and came up with this structure. The spellbook should contain fee rates for every pair by minute, since the deployment of each pair.
Once live, a swap can be simply joined like this.
Sample
Filtered version with a single pair
https://dune.com/queries/3677413?sidebar=none
Thoughts
sqlfmt
, lmk if this matches your coding style!