-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solana orca price #5863
Add solana orca price #5863
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Workflow run id 8907506115 approved. |
Workflow run id 8907506241 approved. |
I have read the CLA Document and I hereby sign the CLA |
Workflow run id 8907566878 approved. |
Workflow run id 8907567112 approved. |
Workflow run id 8907617694 approved. |
Workflow run id 8907617829 approved. |
Workflow run id 8907750040 approved. |
Workflow run id 8907750129 approved. |
Workflow run id 8907892268 approved. |
Workflow run id 8907892356 approved. |
Workflow run id 8907972252 approved. |
Workflow run id 8907972348 approved. |
Workflow run id 8932353110 approved. |
Workflow run id 8932353183 approved. |
Hey I think it is ready to review |
Workflow run id 8933096407 approved. |
Workflow run id 8933096555 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, looks good. nice clean PR here, thank you!
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Dune Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Thank you for contributing to Spellbook!
Thank you for taking the time to submit code in Spellbook. A few things to consider:
Best practices
To speed up your development process in PRs, keep these tips in mind:
readme
) and rundbt compile
target/
directory to copy/paste and run on Dune directly for initial query testingWHERE
filter for only ~7 days of history on large source tables, i.e.ethereum.transactions
Incremental model setup
COALESCE()
as needed on key column(s), otherwise the tests may fail on duplicates🪄 Use the built CI tables for testing 🪄
Once CI completes, you can query the CI tables and errors in dune when it finishes running.
run initial models
andtest initial models
, there will be a schema that looks like this:test_schema.git_dunesql_4da8bae_sudoswap_v2_base_pool_creations
Leverage these tables to perform QA testing on Dune query editor -- or even full test dashboards!
Spellbook contribution docs
The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each
.md
file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄Example questions to be answered:
Please navigate through the docs directory to find as much info as you can.
Note: happy to take PRs to improve the docs, let us know 🤝