-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dex sector subproject creation #6161
Conversation
main spellbook project ran all models successfully: an old test failed, but we don't run in prod or ongoing basis, so not worried about it. considering main spellbook project fine in this PR. |
attempting to run the full dex subproject with a dummy change to CI pipeline to remove edit: |
@@ -1,37 +0,0 @@ | |||
-- Given a list of trades, when we look at their partial_fill, based on the type of the trade we expect partial_fill to behave differently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to keep these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they were valuable in development phase, but don't really add value moving forward. we don't run the tests any time and it's hyper focused on one tx. we can keep, but feels like a good opportunity to cleanse the project
This reverts commit 1672016.
i'm considering this ready to go. feel free to give final review monday morning and push any changes you see fit. happy to help finalize when i'm online monday, otherwise you can do before i'm online 🤝 edit: |
update:
dbt compile
is complete on main spellbook project ✅dbt compile
is complete on dex project ✅run subproject end-to-end (increase CI cluster if needed)...maybe more