Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix price tokens and set up tests #6262

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Jun 26, 2024

There's a a bad price token currently that is producing duplicates as it's reported as the 0x000.. address. (which is used to represent native tokens in many spells)
This will remove it from tokens and set up tests to discover it.
image

cc: @MSilb7 the core of this is originating from tokens_optimism.erc20_bridged_mapping, can you handle this edge case there? It might be a bad emitted event?

@0xRobin 0xRobin mentioned this pull request Jun 26, 2024
@0xRobin 0xRobin marked this pull request as ready for review June 26, 2024 09:06
@0xRobin 0xRobin requested review from jeff-dude and aalan3 June 26, 2024 09:06
@0xRobin 0xRobin added dune team created by dune team hotfix labels Jun 26, 2024
@0xRobin
Copy link
Collaborator Author

0xRobin commented Jun 26, 2024

here are 2 transactions that have caused this:

select * from optimism_ethereum.L1StandardBridge_evt_ERC20DepositInitiated
where l2Token = 0x0000000000000000000000000000000000000000

0xd251d574ec579f51f3d4761fa69b6f704ad302a392da430e2b2059693af10490
0x04215b5421cf276e1345afdfaad0aa564320085d6001447419389b67c9bb068f

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed on our call, good to go here. next steps:

  • lets this run and refresh prices.usd
  • run nft_trades_beta+
  • run dex_base_trades+ (jeff to confirm that's sufficient)

this will fix rows that incorrectly joined to prices and grabbed wrong price, therefore assigning incorrect amount_usd

@jeff-dude jeff-dude merged commit 625919b into duneanalytics:main Jun 26, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
@jeff-dude
Copy link
Member

discussed on our call, good to go here. next steps:

  • lets this run and refresh prices.usd
  • run nft_trades_beta+
  • run dex_base_trades+ (jeff to confirm that's sufficient)

this will fix rows that incorrectly joined to prices and grabbed wrong price, therefore assigning incorrect amount_usd

this is all done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dune team created by dune team hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants