Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing tokens to tokens.erc20 and prices.usd #6293

Merged
merged 6 commits into from
Jul 3, 2024
Merged

add missing tokens to tokens.erc20 and prices.usd #6293

merged 6 commits into from
Jul 3, 2024

Conversation

viniabussafi
Copy link
Contributor

@viniabussafi viniabussafi commented Jul 1, 2024 •
edited
Loading

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix
  • [ ]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: This PR adds tokens that were registered on balancer pools and are missing on tokens.erc20 and prices.usd. Sources of information have been added as comments to each token added.
    Note: tests are going to fail due to zkevm not being properly set up yet

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9741241695 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9741241938 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9741241959 approved.

viniabussafi
viniabussafi commented Jul 1, 2024
View reviewed changes
models/prices/arbitrum/prices_arbitrum_tokens.sql Outdated
@@ -198,5 +198,6 @@ FROM
('a51-a51-finance','arbitrum','A51',0xb3f13b0c61d65d67d7d6215d70c89533ee567a91, 18),
('oseth-stakewise-staked-eth','arbitrum','osETH',0xf7d4e7273e5015c96728a6b02f31c505ee184603, 18),
('sliz-solidlizard-dex-token','arbitrum','SLIZ',0x463913D3a3D3D291667D53B8325c598Eb88D3B0e, 18),
('vrtx-vertex-protocol', 'arbitrum', 'VRTX', 0x95146881b86b3ee99e63705ec87afe29fcc044d9, 18)
('vrtx-vertex-protocol', 'arbitrum', 'VRTX', 0x95146881b86b3ee99e63705ec87afe29fcc044d9, 18),
('gho-gho', 'arbitrum', 'GHO', 0x7dff72693f6a4149b17e7c6314655f6a9f7c8b33, 18),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://coinpaprika.com/coin/gho-gho/

viniabussafi
viniabussafi commented Jul 1, 2024
View reviewed changes
tokens/models/tokens/arbitrum/tokens_arbitrum_erc20.sql
@@ -82,4 +82,7 @@ FROM (VALUES
, (0xD460f305B150Bc70b063E806815B50BebE9F21b1, 'APRTo', 18)
, (0x577fd586c9e6ba7f2e85e025d5824dbe19896656, 'SYNO', 18)
, (0x6985884c4392d348587b19cb9eaaf157f13271cd, 'ZRO', 18)
, (0x5a7a183b6b44dc4ec2e3d2ef43f98c5152b1d76d, 'inETH', 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://arbiscan.io/address/0x5a7a183b6b44dc4ec2e3d2ef43f98c5152b1d76d

viniabussafi
viniabussafi commented Jul 1, 2024
View reviewed changes
tokens/models/tokens/arbitrum/tokens_arbitrum_erc20.sql
@@ -82,4 +82,7 @@ FROM (VALUES
, (0xD460f305B150Bc70b063E806815B50BebE9F21b1, 'APRTo', 18)
, (0x577fd586c9e6ba7f2e85e025d5824dbe19896656, 'SYNO', 18)
, (0x6985884c4392d348587b19cb9eaaf157f13271cd, 'ZRO', 18)
, (0x5a7a183b6b44dc4ec2e3d2ef43f98c5152b1d76d, 'inETH', 18)
, (0xd08c3f25862077056cb1b710937576af899a4959, 'instETH', 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://arbiscan.io/address/0xd08c3f25862077056cb1b710937576af899a4959

viniabussafi
viniabussafi commented Jul 1, 2024
View reviewed changes
tokens/models/tokens/arbitrum/tokens_arbitrum_erc20.sql
@@ -82,4 +82,7 @@ FROM (VALUES
, (0xD460f305B150Bc70b063E806815B50BebE9F21b1, 'APRTo', 18)
, (0x577fd586c9e6ba7f2e85e025d5824dbe19896656, 'SYNO', 18)
, (0x6985884c4392d348587b19cb9eaaf157f13271cd, 'ZRO', 18)
, (0x5a7a183b6b44dc4ec2e3d2ef43f98c5152b1d76d, 'inETH', 18)
, (0xd08c3f25862077056cb1b710937576af899a4959, 'instETH', 18)
, (0x7dff72693f6a4149b17e7c6314655f6a9f7c8b33, 'GHO', 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://arbiscan.io/address/0x7dff72693f6a4149b17e7c6314655f6a9f7c8b33

viniabussafi
viniabussafi commented Jul 1, 2024
View reviewed changes
tokens/models/tokens/ethereum/tokens_ethereum_erc20.sql
@@ -4566,4 +4566,8 @@ FROM (VALUES
, ( 0x10dea67478c5f8c5e2d90e5e9b26dbe60c54d800, 'TAIKO', 18)
, ( 0x80ac24aA929eaF5013f6436cdA2a7ba190f5Cc0b, 'syrupUSDC', 6)
, ( 0xa8258deE2a677874a48F5320670A869D74f0cbC1, 'WAR', 18)
, ( 0xbeef69ac7870777598a04b2bd4771c71212e6abc, 'steakLRT', 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://etherscan.io/address/0xbeef69ac7870777598a04b2bd4771c71212e6abc

viniabussafi
viniabussafi commented Jul 1, 2024
View reviewed changes
tokens/models/tokens/ethereum/tokens_ethereum_erc20.sql
@@ -4566,4 +4566,8 @@ FROM (VALUES
, ( 0x10dea67478c5f8c5e2d90e5e9b26dbe60c54d800, 'TAIKO', 18)
, ( 0x80ac24aA929eaF5013f6436cdA2a7ba190f5Cc0b, 'syrupUSDC', 6)
, ( 0xa8258deE2a677874a48F5320670A869D74f0cbC1, 'WAR', 18)
, ( 0xbeef69ac7870777598a04b2bd4771c71212e6abc, 'steakLRT', 18)
, ( 0x84631c0d0081fde56deb72f6de77abbbf6a9f93a, 'Re7LRT', 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://etherscan.io/address/0x84631c0d0081fde56deb72f6de77abbbf6a9f93a

viniabussafi
viniabussafi commented Jul 1, 2024
View reviewed changes
tokens/models/tokens/ethereum/tokens_ethereum_erc20.sql
@@ -4566,4 +4566,8 @@ FROM (VALUES
, ( 0x10dea67478c5f8c5e2d90e5e9b26dbe60c54d800, 'TAIKO', 18)
, ( 0x80ac24aA929eaF5013f6436cdA2a7ba190f5Cc0b, 'syrupUSDC', 6)
, ( 0xa8258deE2a677874a48F5320670A869D74f0cbC1, 'WAR', 18)
, ( 0xbeef69ac7870777598a04b2bd4771c71212e6abc, 'steakLRT', 18)
, ( 0x84631c0d0081fde56deb72f6de77abbbf6a9f93a, 'Re7LRT', 18)
, ( 0x7a4effd87c2f3c55ca251080b1343b605f327e3a, 'rstETH', 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://etherscan.io/address/0x7a4effd87c2f3c55ca251080b1343b605f327e3a

viniabussafi
viniabussafi commented Jul 1, 2024
View reviewed changes
tokens/models/tokens/ethereum/tokens_ethereum_erc20.sql
, ( 0xbeef69ac7870777598a04b2bd4771c71212e6abc, 'steakLRT', 18)
, ( 0x84631c0d0081fde56deb72f6de77abbbf6a9f93a, 'Re7LRT', 18)
, ( 0x7a4effd87c2f3c55ca251080b1343b605f327e3a, 'rstETH', 18)
, ( 0x5fd13359ba15a84b76f7f87568309040176167cd, 'amprETH', 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://etherscan.io/address/0x5fd13359ba15a84b76f7f87568309040176167cd

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9741447436 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9741447590 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9741447626 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9741447622 approved.

@viniabussafi viniabussafi marked this pull request as ready for review July 1, 2024 09:24
@viniabussafi viniabussafi marked this pull request as draft July 1, 2024 09:48
@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9742628099 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9742628241 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9742628225 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9742628246 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9742761689 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9742761549 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9742761656 approved.

@dune-eng
Copy link

dune-eng commented Jul 1, 2024

Workflow run id 9742761713 approved.

@viniabussafi viniabussafi marked this pull request as ready for review July 1, 2024 10:50
@Hosuke Hosuke self-assigned this Jul 2, 2024
@Hosuke Hosuke added the in review Assignee is currently reviewing the PR label Jul 2, 2024
Hosuke
Hosuke approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @viniabussafi

@Hosuke Hosuke added easy ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jul 2, 2024
@aalan3 aalan3 merged commit bd3795c into duneanalytics:main Jul 3, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@viniabussafi viniabussafi deleted the _tok branch September 17, 2024 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hosuke Hosuke Hosuke approved these changes

Assignees

@Hosuke Hosuke

Labels
easy ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viniabussafi @dune-eng @Hosuke @aalan3