Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add price of wcomai #6305

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Add price of wcomai #6305

merged 2 commits into from
Jul 3, 2024

Conversation

rivusdao
Copy link
Contributor

@rivusdao rivusdao commented Jul 2, 2024

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@dune-eng
Copy link

dune-eng commented Jul 2, 2024

Workflow run id 9756005757 approved.

@dune-eng
Copy link

dune-eng commented Jul 2, 2024

Workflow run id 9756005879 approved.

@dune-eng
Copy link

dune-eng commented Jul 2, 2024

Workflow run id 9756005905 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @rivusdao

@dune-eng
Copy link

dune-eng commented Jul 2, 2024

Workflow run id 9762725517 approved.

@dune-eng
Copy link

dune-eng commented Jul 2, 2024

Workflow run id 9762725618 approved.

@dune-eng
Copy link

dune-eng commented Jul 2, 2024

Workflow run id 9762725588 approved.

@rivusdao
Copy link
Contributor Author

rivusdao commented Jul 2, 2024

when this branch will get merge?

@aalan3 aalan3 merged commit 1340191 into duneanalytics:main Jul 3, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants