Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOR REVIEW] Add ZeroEx Settler trades on BNB #6431

Merged
merged 100 commits into from
Jul 30, 2024

Conversation

RantumBits
Copy link
Contributor

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name zeroex_bnb.settler_trades
  • Description: [Detailed description of the new spell(s) and their purpose] decode 0x API trades on new settler contracts on BNB chain
  • Who are the new spell(s) for? [Internal team or general community] both
  • How will the new spell(s) be used downstream? [Description of downstream usage] merged into dex-agg.trades
  • Implementation details: [Information on how the spell(s) are implemented] gets taker and maker amounts only, no fills level data for intermediary swaps
  • Test instructions: [How to test the new spell(s)] https://dune.com/queries/3921632- Related issue(s): [Link to related issues, if any]

RantumBits and others added 30 commits June 1, 2021 14:07
@dune-eng
Copy link

Workflow run id 10098839824 approved.

@dune-eng
Copy link

Workflow run id 10098839815 approved.

@RantumBits RantumBits marked this pull request as ready for review July 25, 2024 17:45
@RantumBits RantumBits changed the title Add ZeroEx Settler trades on BNB [FOR REVIEW] Add ZeroEx Settler trades on BNB Jul 25, 2024
@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review dbt: dex covers the DEX dbt subproject labels Jul 25, 2024
@jeff-dude jeff-dude requested a review from Hosuke July 25, 2024 18:49
@dune-eng
Copy link

Workflow run id 10102747365 approved.

@dune-eng
Copy link

Workflow run id 10102747837 approved.

@dune-eng
Copy link

Workflow run id 10102747842 approved.

@RantumBits
Copy link
Contributor Author

updated to match requested changes on #6425

@Hosuke
Copy link
Collaborator

Hosuke commented Jul 29, 2024

Please resolve conflicts in other similar PRs first. Thank you.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hosuke Hosuke added ready-for-final-review and removed ready-for-review this PR development is complete, please review labels Jul 29, 2024
@Hosuke Hosuke removed their assignment Jul 29, 2024
@jeff-dude jeff-dude merged commit 12456b8 into duneanalytics:main Jul 30, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@RantumBits RantumBits deleted the settler-bnb branch August 9, 2024 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants