Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bright Moments collection list updates #6469

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

catherine-2
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: Adding all of the new collections to the Bright Moments metadata table since I last updated it.

Thank you for your contribution!

Copy link

github-actions bot commented Jul 31, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dune-eng
Copy link

Workflow run id 10174817150 approved.

@dune-eng
Copy link

Workflow run id 10174817248 approved.

@catherine-2
Copy link
Contributor Author

Hi! This should hopefully be an easy review - just adding updated static metadata.

It's been awhile since I made an PR and I'm not sure how to fix the CLA failure in order to sign the new agreement? Thank you!

@catherine-2
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@catherine-2
Copy link
Contributor Author

Recheck

1 similar comment
@catherine-2
Copy link
Contributor Author

Recheck

github-actions bot added a commit that referenced this pull request Jul 31, 2024
@dune-eng
Copy link

Workflow run id 10183776245 approved.

@dune-eng
Copy link

Workflow run id 10183776081 approved.

@catherine-2
Copy link
Contributor Author

This is ready for review and merge! Thank you!

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome back 🫡

@catherine-2
Copy link
Contributor Author

welcome back 🫡

Thank you!! Excited to be back ❤️

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10203185483 approved.

@dune-eng
Copy link

dune-eng commented Aug 1, 2024

Workflow run id 10203185343 approved.

@catherine-2
Copy link
Contributor Author

Made two tiny fixes as I was triple checking the PR. Ready to merge again. Thank you!

@jeff-dude jeff-dude merged commit 7f45c60 into duneanalytics:main Aug 1, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Aug 1, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Dune Contributor:

GitPOAP: 2024 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants