Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Metadata Spells #6576

Merged
merged 10 commits into from
Aug 20, 2024
Merged

New Metadata Spells #6576

merged 10 commits into from
Aug 20, 2024

Conversation

catherine-2
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): 3 new spells:
  1. nft_ethereum_metadata_xcopy_collections
  2. nft_ethereum_metadata_xcopy_nonsequential_tokens
  3. nft_ethereum_metadata_xcopy_full_list
  • Description: Adding static metadata tables that have details for all of XCOPY's NFTs. XCOPY has minted on 40 different contracts so it is complicated for wizards to pull data on their collection. This enables anyone to easily pull XCOPY data on Dune

  • Who are the new spell(s) for? General community - wizards focused on NFTs specifically

  • How will the new spell(s) be used downstream? Wizards can use these three new tables to join on any other common table - e.g. nft trades, erc721 transfers - to pull data on XCOPY's NFTs and collectors. I re-built my XCOPY dashboard (dune.com/cat/xcopy) as an example completely off of these 3 tables (currently done via queries but will switch over to the spells once merged).

  • Implementation details: I pulled together a static list of all of the works XCOPY has minted with contract_address and token_id details as well as other key information (e.g. title, platform minted on)

  • Test instructions: See queries on XCOPY dashboard that uses them already

  • Related issue(s): N/A


Thank you for your contribution!

@dune-eng
Copy link

Workflow run id 10446138377 approved.

@dune-eng
Copy link

Workflow run id 10446138388 approved.

@dune-eng
Copy link

Workflow run id 10446192290 approved.

@dune-eng
Copy link

Workflow run id 10446192391 approved.

@dune-eng
Copy link

Workflow run id 10446203325 approved.

@dune-eng
Copy link

Workflow run id 10446203469 approved.

@catherine-2
Copy link
Contributor Author

Hi! This is ready for review and merge. I tested the tables on Dune and filled out the questions in the first comment in this PR above with context on the new spells. Please let me know if you have any questions or feedback! Thank you!

@dune-eng
Copy link

Workflow run id 10453920664 approved.

@dune-eng
Copy link

Workflow run id 10453920878 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file may be hard for maintainence though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tried to it as simple as possible. There are a lot of collections there now since XCOPY has been minting for more than 6 years but going forward it should just require adding < 10 lines per year (assuming they maintain their current mint rate).

@Hosuke Hosuke added the ready-for-review this PR development is complete, please review label Aug 19, 2024
@dune-eng
Copy link

Workflow run id 10455527588 approved.

@dune-eng
Copy link

Workflow run id 10455527978 approved.

@catherine-2
Copy link
Contributor Author

@Hosuke I just realized I want to make 2 of the spells exposed on Dune. Could you check my syntax is correct in the latest commit? This will be the final edit - thank you!

@Hosuke
Copy link
Collaborator

Hosuke commented Aug 20, 2024

@Hosuke I just realized I want to make 2 of the spells exposed on Dune. Could you check my syntax is correct in the latest commit? This will be the final edit - thank you!

We may need to apply the new format for the post_hook like:

        post_hook='{{ expose_spells(blockchains = \'["ethereum"]\',
                                    spell_type = "sector",
                                    spell_name = "rebase",
                                    contributors = \'["hildobby"]\') }}'

@dune-eng
Copy link

Workflow run id 10473605436 approved.

@dune-eng
Copy link

Workflow run id 10473605794 approved.

@catherine-2
Copy link
Contributor Author

catherine-2 commented Aug 20, 2024

@Hosuke I just realized I want to make 2 of the spells exposed on Dune. Could you check my syntax is correct in the latest commit? This will be the final edit - thank you!

We may need to apply the new format for the post_hook like:

        post_hook='{{ expose_spells(blockchains = \'["ethereum"]\',
                                    spell_type = "sector",
                                    spell_name = "rebase",
                                    contributors = \'["hildobby"]\') }}'

Thank you! Just updated that. Hopefully all good to merge now!

@dune-eng
Copy link

Workflow run id 10473629912 approved.

@dune-eng
Copy link

Workflow run id 10473630046 approved.

@jeff-dude jeff-dude self-assigned this Aug 20, 2024
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Aug 20, 2024
@jeff-dude jeff-dude merged commit 7df7dce into duneanalytics:main Aug 20, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants