-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Metadata Spells #6576
New Metadata Spells #6576
Conversation
Workflow run id 10446138377 approved. |
Workflow run id 10446138388 approved. |
Workflow run id 10446192290 approved. |
Workflow run id 10446192391 approved. |
Workflow run id 10446203325 approved. |
Workflow run id 10446203469 approved. |
Hi! This is ready for review and merge. I tested the tables on Dune and filled out the questions in the first comment in this PR above with context on the new spells. Please let me know if you have any questions or feedback! Thank you! |
Workflow run id 10453920664 approved. |
Workflow run id 10453920878 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅
Thank you @catherine-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file may be hard for maintainence though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I tried to it as simple as possible. There are a lot of collections there now since XCOPY has been minting for more than 6 years but going forward it should just require adding < 10 lines per year (assuming they maintain their current mint rate).
Workflow run id 10455527588 approved. |
Workflow run id 10455527978 approved. |
@Hosuke I just realized I want to make 2 of the spells exposed on Dune. Could you check my syntax is correct in the latest commit? This will be the final edit - thank you! |
We may need to apply the new format for the
|
Workflow run id 10473605436 approved. |
Workflow run id 10473605794 approved. |
Thank you! Just updated that. Hopefully all good to merge now! |
Workflow run id 10473629912 approved. |
Workflow run id 10473630046 approved. |
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
Description: Adding static metadata tables that have details for all of XCOPY's NFTs. XCOPY has minted on 40 different contracts so it is complicated for wizards to pull data on their collection. This enables anyone to easily pull XCOPY data on Dune
Who are the new spell(s) for? General community - wizards focused on NFTs specifically
How will the new spell(s) be used downstream? Wizards can use these three new tables to join on any other common table - e.g. nft trades, erc721 transfers - to pull data on XCOPY's NFTs and collectors. I re-built my XCOPY dashboard (dune.com/cat/xcopy) as an example completely off of these 3 tables (currently done via queries but will switch over to the spells once merged).
Implementation details: I pulled together a static list of all of the works XCOPY has minted with contract_address and token_id details as well as other key information (e.g. title, platform minted on)
Test instructions: See queries on XCOPY dashboard that uses them already
Related issue(s): N/A
Thank you for your contribution!