Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUX-620 cleanup and fix data explorer entries #6590

Merged
merged 3 commits into from
Aug 21, 2024
Merged

DUX-620 cleanup and fix data explorer entries #6590

merged 3 commits into from
Aug 21, 2024

Conversation

jeff-dude
Copy link
Member

No description provided.

@jeff-dude jeff-dude changed the title cleanup and fix data explorer entries DUX-620 cleanup and fix data explorer entries Aug 21, 2024
Comment on lines +7 to +8
spell_type = "sector",
spell_name = "nft_ethereum_metadata",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @catherine-2
the param names are confusing, but spell_type needs to be either: sector or project and then we can name spell_name what we'd like, but i'll choose schema name here to make it easy to find in data explorer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to clean up usage of this post hook to simplify but need to find a way to do so without breaking anything, hopefully soon!

@jeff-dude
Copy link
Member Author

canceling CI and running in prod without modified enabled to avoid unnecessary refreshes

@jeff-dude jeff-dude merged commit a9a36ac into main Aug 21, 2024
2 of 3 checks passed
@jeff-dude jeff-dude deleted the cleanup-DE branch August 21, 2024 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant