Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static EVM Stablecoins #6723

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Static EVM Stablecoins #6723

merged 11 commits into from
Sep 18, 2024

Conversation

Synthquest
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • [ x] New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): tokens.tokens_erc20_stablecoins
  • Description: contract, description, and decimal definitions for L1 & L2 evm stablecoins
  • Who are the new spell(s) for? general community + internal work
  • How will the new spell(s) be used downstream?
    General - quick views of stablecoins on l2's.

Internal - filter for token transfers

  • Implementation details: static
  • Test instructions: unique contract address + blockchain
  • Related issue(s): N/A

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

## Thank you for contributing to Spellbook 🪄

### Update!
Please build spells in the proper [subproject](../dbt_subprojects/) directory. For more information, please see the main [readme](../README.md), which also links to a GH discussion with the option to ask questions.

### Contribution type
Please check the type of contribution this pull request is for:

- [ x] New spell(s)
- [ ] Adding to existing spell lineage
- [ ] Bug fix

**Note:** You can safely discard any section below which doesn't apply based on selection above

---

### For new spell(s)
If you are building new spell(s), please provide the following information:

- **Spell name(s):** *tokens.tokens_erc20_stablecoins*
- **Description:** contract, description, and decimal definitions for L1 & L2 evm stablecoins
- **Who are the new spell(s) for?** general community + internal work
- **How will the new spell(s) be used downstream?**
General - quick views of stablecoins on l2's.

Internal -  filter for token transfers

- **Implementation details:** static
- **Test instructions:** unique contract address + blockchain
- **Related issue(s):** N/A

---

### For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:

- **Description:** [Description of the changes made]

---

### For bug fixes
If you are fixing a bug, please provide the following information:

- **Description:** [Description of the bug fix]
- **Steps to reproduce:** [How to reproduce the bug]
- **Implementation details:** [Information on how the bug was fixed]
- **Test instructions:** [How to test the fix]
- **Related issue(s):** [Link to related issues, if any]

---

### Additional information
Please provide any additional information that might help us review your pull request:

- [Any additional information]

---

Thank you for your contribution!
@dune-eng
Copy link

Workflow run id 10892513068 approved.

@dune-eng
Copy link

Workflow run id 10892513082 approved.

@Synthquest Synthquest changed the title Main Static EVM Stablecoins Sep 16, 2024
@dune-eng
Copy link

Workflow run id 10892659912 approved.

@dune-eng
Copy link

Workflow run id 10892659920 approved.

@Synthquest Synthquest marked this pull request as ready for review September 16, 2024 22:00
@dune-eng
Copy link

Workflow run id 10905398886 approved.

@dune-eng
Copy link

Workflow run id 10905398632 approved.

@jeff-dude jeff-dude self-assigned this Sep 17, 2024
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR question Further information is requested labels Sep 17, 2024
@jeff-dude
Copy link
Member

@Synthquest it looks like we already have some initial start on stablecoin spells, an example here for ethereum. if you go back a directory, other chains also exist. can we combine the efforts here with those existing ones, to have one approach on stablecoins? then we can have a crosschain spell on top of all chain specific ones, similar to tokens_erc20?

@Synthquest
Copy link
Contributor Author

@Synthquest it looks like we already have some initial start on stablecoin spells, an example here for ethereum. if you go back a directory, other chains also exist. can we combine the efforts here with those existing ones, to have one approach on stablecoins? then we can have a crosschain spell on top of all chain specific ones, similar to tokens_erc20?

Sure, do you want to update the schema of these or keep the schema the same? I ask only because certain chains do not follow the same schema.

Optimism for instance:
https://github.com/duneanalytics/spellbook/blob/main/dbt_subprojects/tokens/models/tokens/optimism/tokens_optimism_erc20_stablecoins.sql

I'm also seeing a separate labels.stablecoins table on dune

@dune-eng
Copy link

Workflow run id 10914179974 approved.

@dune-eng
Copy link

Workflow run id 10914180199 approved.

@dune-eng
Copy link

Workflow run id 10914289179 approved.

@dune-eng
Copy link

Workflow run id 10914289207 approved.

@dune-eng
Copy link

Workflow run id 10914461200 approved.

@dune-eng
Copy link

Workflow run id 10914461275 approved.

@Synthquest
Copy link
Contributor Author

@jeff-dude
I ran through adding in new chain tables, appending any stables from the existing tables, and normalizing to a standardized schema for all chains. Please let me know if we should change any naming conventions / column formats

@dune-eng
Copy link

Workflow run id 10923947132 approved.

@dune-eng
Copy link

Workflow run id 10923947170 approved.

@dune-eng
Copy link

Workflow run id 10924060406 approved.

@dune-eng
Copy link

Workflow run id 10924060378 approved.

@dune-eng
Copy link

Workflow run id 10924231499 approved.

@dune-eng
Copy link

Workflow run id 10924231860 approved.

@dune-eng
Copy link

Workflow run id 10924852553 approved.

@dune-eng
Copy link

Workflow run id 10924852895 approved.

@jeff-dude
Copy link
Member

this is looking good to me. plz do explicitly add schema property in each model though, rather than rely on value in dbt project file.

@jeff-dude jeff-dude added WIP work in progress and removed question Further information is requested labels Sep 18, 2024
@dune-eng
Copy link

Workflow run id 10927504596 approved.

@dune-eng
Copy link

Workflow run id 10927504890 approved.

@Synthquest
Copy link
Contributor Author

Schema properties added

@jeff-dude jeff-dude removed WIP work in progress in review Assignee is currently reviewing the PR labels Sep 18, 2024
@jeff-dude jeff-dude merged commit fdd0124 into duneanalytics:main Sep 18, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants