dex.trades: add HOT-AMM support

[0xrusowsky]

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

• New spell(s)
• Adding to existing spell lineage
• Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above

---

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

• Description:
  • Added dex.trades support for HOT-AMM, a new AMM developed by Valantis and Arrakis.
  • Added valantis support in dex_info
  • So far the AMM is only deployed on mainnet and arbitrum, so i added those sources and created a macro to process the data.

[dune-eng]

Workflow run id 10899696880 approved.

[dune-eng]

Workflow run id 10899697283 approved.

[dune-eng]

Workflow run id 10900135371 approved.

[dune-eng]

Workflow run id 10900135587 approved.

[dune-eng]

Workflow run id 10900148226 approved.

[dune-eng]

Workflow run id 10900148669 approved.

[dune-eng]

Workflow run id 10900493929 approved.

[dune-eng]

Workflow run id 10900494094 approved.

[0xrusowsky]

hey guys! @Hosuke @jeff-dude
sorry to tag u directly, but i'm trying to add support for a new amm on dex.trades and despite the project compiles, i am facing some CI errors that i don't understand.

could you please have a look whenever u have time?

thanks a lot!

[dune-eng]

Workflow run id 10923004720 approved.

[dune-eng]

Workflow run id 10923005212 approved.

[dune-eng]

Workflow run id 10924078967 approved.

[dune-eng]

Workflow run id 10924079296 approved.

[0xrusowsky]

@jeff-dude @Hosuke the query results LGTM, i'd say it is ready for review 🙂

thanks!

[0xrusowsky]

also, something which may be worth mentioning is that this dex is already live, so idk if data will be backfilled automatically or if it is possible to do it manually (it is not a big deal, but flagging that just in case)

[jeff-dude]

a bit confused on the hot_amm vs. valantis relationship and naming standards. based on the code, i would think all of these spells should be named valantis?

[0xrusowsky]

a bit confused on the hot_amm vs. valantis relationship and naming standards. based on the code, i would think all of these spells should be named valantis?

@jeff-dude i'm flexible on the naming, and we can change it to accommodate what u think its best. let me try to explain how it works (high-level as i don't fully know all the technical details):
valantis is a new DEX protocol that has 2 pool types:

• sovereign pools
• universal pools

sovereign pools are like the building block for a modular dex, and on top of them, you can add your liquidity module (here is where HOT-AMM comes into play) >> Arrakis and Valantis co-design the idea of a Hybrid-Order-Type (HOT) AMM which is accepts both RFQ quotes and permisionless swaps (like uniV3).

for further details, here you have their docs:

• https://docs.valantis.xyz/
• https://docs.valantis.xyz/hot

---

my logic when naming stuff was that down the line, more pool types may be built on top of valantis (idk how feasible that is, but it's possible), so i named hot_amm the stuff that is related to the HOT liquidity module (contract that emits HOT_evt_HotSwap).

if you feel like everything should be named valantis i'm cool with that haha, was just trying to create future-proof stuff

[jeff-dude]

a bit confused on the hot_amm vs. valantis relationship and naming standards. based on the code, i would think all of these spells should be named valantis?

@jeff-dude i'm flexible on the naming, and we can change it to accommodate what u think its best. let me try to explain how it works (high-level as i don't fully know all the technical details): valantis is a new DEX protocol that has 2 pool types:

• sovereign pools
• universal pools

sovereign pools are like the building block for a modular dex, and on top of them, you can add your liquidity module (here is where HOT-AMM comes into play) >> Arrakis and Valantis co-design the idea of a Hybrid-Order-Type (HOT) AMM which is accepts both RFQ quotes and permisionless swaps (like uniV3).

for further details, here you have their docs:

• https://docs.valantis.xyz/
• https://docs.valantis.xyz/hot

my logic when naming stuff was that down the line, more pool types may be built on top of valantis (idk how feasible that is, but it's possible), so i named hot_amm the stuff that is related to the HOT liquidity module (contract that emits HOT_evt_HotSwap).

if you feel like everything should be named valantis i'm cool with that haha, was just trying to create future-proof stuff

how about valantis_hot_amm_<chain>? this matches your version value in the spell too (hot). or maybe even do just valantis_hot_<chain> to match version name?

then future additions can be valantis_<version>_<chain>

[0xrusowsky]

sounds good to me! will do the changes

[dune-eng]

Workflow run id 10925846492 approved.

[dune-eng]

Workflow run id 10925846465 approved.