-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade transfers_enrich macro and benchmark prices.hour #7077
base: main
Are you sure you want to change the base?
Conversation
A CI error I am not very sure here: |
Test result using 10 days:
Different rows: |
this difference in coverage is shocking. the new dataset is supposed to have 100x or more coverage of tokens. is this isolated to blast chain, where the new prices tables haves v few tokens? or is it possible the queries have a bug? |
not sure on this CI error. is this happening every run? i guess not, since you were able to build test tables? i am able to query both the view |
…ke/spellbook into 1031-tokens-transfers-upgrade
Though
Here is an overview of overlapping tokens count: I think it is possible my queries have a bug... Another possibility is the |
yes, use random historical timeframe to test to be safe. something like oct 1st 2024 - oct 10th 2024 (or something like that) |
, prices_model = null | ||
, evms_info_model = null | ||
, transfers_start_date = '2000-01-01' | ||
, transfers_end_date = '9999-12-31' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding transfers_end_date
param for benchmark and testing.
ethereum.transfers coverage test:
blast.transfers coverage test:
|
This reverts commit ebc1554.
This reverts commit 6843eb9.
Repeat the experiments above, a slightly different result: ethereum.transfers coverage test:
blast.transfers coverage test:
|
Benchmark macro's performance with
prices.usd
andprices.hour