Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow using authorization query parameter #655

Merged
merged 1 commit into from
Jun 20, 2022
Merged

feat: allow using authorization query parameter #655

merged 1 commit into from
Jun 20, 2022
+157 −2

Conversation

azjezz
Copy link
Contributor

@azjezz azjezz commented Jun 17, 2022

closes #387

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@azjezz azjezz force-pushed the feat/query-authorization branch from f565ef7 to 0faa55f Compare June 17, 2022 14:08
dunglas
dunglas approved these changes Jun 17, 2022
View reviewed changes
@azjezz azjezz force-pushed the feat/query-authorization branch from 0faa55f to 75a57ff Compare June 17, 2022 14:37
@dunglas
Copy link
Owner

dunglas commented Jun 17, 2022

Could you also add some config in Caddyfile to strip the value of the authorization query parameter from the logs? https://dunglas.fr/2022/04/caddy-logging-security-improvements/

@azjezz azjezz force-pushed the feat/query-authorization branch 2 times, most recently from 92e4104 to f31d2de Compare June 18, 2022 23:38
@azjezz
Copy link
Contributor Author

azjezz commented Jun 18, 2022

tests are passing 👍

@azjezz
feat: allow using authorization query parameter
96c1260 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz force-pushed the feat/query-authorization branch from f31d2de to 96c1260 Compare June 19, 2022 13:08
@dunglas dunglas merged commit 9764824 into dunglas:main Jun 20, 2022
@dunglas
Copy link
Owner

dunglas commented Jun 20, 2022

Thanks @azjezz

@azjezz azjezz deleted the feat/query-authorization branch June 20, 2022 15:10
@azjezz azjezz mentioned this pull request Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication with multiple JWT tokens from the same browser session
3 participants
@azjezz @CLAassistant @dunglas