feat: Add CADDY_EXTRA_DIRECTIVES #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dunglas
requested changes
Jul 6, 2022
dunglas
reviewed
Jul 6, 2022
| valueFrom: | ||
| configMapKeyRef: | ||
| name: {{ include "mercure.fullname" . }} | ||
| key: extra-directives |
There was a problem hiding this comment.
The config template must be updated as well isn't it? We also need a new value.
Also, I would use a secret as this env var may contains secret keys and things like this, depending on the modules you use.
WDYT?
There was a problem hiding this comment.
I did it, but it may be confusing with extra-directives/extraDirectives, should I change it too?
dunglas
approved these changes
Jul 10, 2022
|
Actually, it works on my computer, can you have a look please? |
|
I'm not sure of what the issue is, but the error in the CI is |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.