Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially update the images #10

Closed
bynect opened this issue Mar 1, 2024 · 12 comments
Closed

Potentially update the images #10

bynect opened this issue Mar 1, 2024 · 12 comments

Comments

@bynect
Copy link
Member

bynect commented Mar 1, 2024

Right now I get a deprecation messages from every action

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, codecov/codecov-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

So we may want to update the images. However I am not an expert in docker (I wrote the last Dockerfile 4/5 years ago) so I am not sure what to do (without breaking anything).

@fwsmit
Copy link
Member

fwsmit commented Mar 3, 2024

The docker files got updated recently. But they need to get rebuilt and pushed to docker hub. I don't know exactly how. I think @bebehei has the credentials for docker hub.

@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

TBH, I have to have a look there.

I guess, I should move this to the GitHub registry, so anyone inside the dunst org can update this without needing to get another permission on another platform.

The docs look just right for this:

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

So, I'm currently testing to build the docker images on GitHub Actions itself.

After spinning up the matrix (I've taken it from our main project), I've hit the same error message, but in Debian Stretch: https://github.com/dunst-project/docker-images/actions/runs/8132245691/job/22222455338

Stretch is totally outdated and we should ignore it. Hence we should drop it from the CI in our main repo.

@bebehei bebehei mentioned this issue Mar 3, 2024
@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

Ok, kind of false alarm with Debian Stretc. The debian strech dockerfile is not available anymore, hence this job failed.

After fixing the matrix list, the build works, but now every matrix job warns with this message.

image

Dafuq? I've just created this pipeline and took the reference code from GitHub docs? Can't they just keep the code up to date?


To derive the actions in main repo:

  • Update the distro list in matrix in main workflow
  • Update the serials from the actions

@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

It's getting wild here. I know, I'm the newbie here, but ... what?

image


I've just created this pipeline and took the reference code from GitHub docs? Can't they just keep the code up to date?

I've checked out the docs from the docker actions itselves. All reference v3 in their docs. But apparently those docs are outdated, too. 🙈

bebehei pushed a commit that referenced this issue Mar 3, 2024
Before this commit, we got the error message in our builds:

```
Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20:
docker/login-action@65b78e6,
docker/metadata-action@9ec57ed,
docker/build-push-action@f2a1d5e. For
more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

Apparently, even the GitHub Docs itself are outdated for the last 5
months.

After visiting all the action's versions, I've pinned it to the freshest
versions.
bebehei added a commit that referenced this issue Mar 3, 2024
Before this commit, we got the error message in our builds:

```
Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20:
docker/login-action@65b78e6,
docker/metadata-action@9ec57ed,
docker/build-push-action@f2a1d5e. For
more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

Apparently, even the GitHub Docs itself are outdated for the last 5
months.

After visiting all the action's versions, I've pinned it to the freshest
versions.
@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

So, it seems like the images can be built now on GitHub Actions, also by yourselves. Additionally, when updating the files here, there is no need to do manual rebuilds.

@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

Ahh, it seems like the package is still not visible. I cannot pull it:

[benediktheine:~/code/dunst/docker-images] master(+8/-14) ± docker pull ghcr.io/dunst-project/docker-images:alpine
Error response from daemon: Head "https://ghcr.io/v2/dunst-project/docker-images/manifests/alpine": unauthorized
[benediktheine:~/code/dunst/docker-images] master(+8/-14) 1 ±

Found a hint in the package's settings:

image

But I'm not allowed to change it:

image

EDIT:

It's in the Org's settings

image

@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

Just found in this repository the old Docker Hub Hooks, removed them.

@bebehei
Copy link
Member

bebehei commented Mar 3, 2024

Oh, this wasn't the brightest action by myself today: I already killed the docker hub dunst organisation. (the old CI cannot run anymore from now, sorry)

@bynect
Copy link
Member Author

bynect commented Mar 4, 2024

good work, I have no clue how to manage docker 😢

@zappolowski
Copy link
Member

@bynect we have new images already running on the CI since a while. Can we close this one?

@bynect
Copy link
Member Author

bynect commented May 1, 2024

Sure

@bynect bynect closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants