-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potentially update the images #10
Comments
The docker files got updated recently. But they need to get rebuilt and pushed to docker hub. I don't know exactly how. I think @bebehei has the credentials for docker hub. |
TBH, I have to have a look there. I guess, I should move this to the GitHub registry, so anyone inside the dunst org can update this without needing to get another permission on another platform. The docs look just right for this: |
So, I'm currently testing to build the docker images on GitHub Actions itself. After spinning up the matrix (I've taken it from our main project), I've hit the same error message, but in Debian Stretch: https://github.com/dunst-project/docker-images/actions/runs/8132245691/job/22222455338 Stretch is totally outdated and we should ignore it. Hence we should drop it from the CI in our main repo. |
Ok, kind of false alarm with Debian Stretc. The debian strech dockerfile is not available anymore, hence this job failed. After fixing the matrix list, the build works, but now every matrix job warns with this message. Dafuq? I've just created this pipeline and took the reference code from GitHub docs? Can't they just keep the code up to date? To derive the actions in main repo:
|
It's getting wild here. I know, I'm the newbie here, but ... what?
I've checked out the docs from the docker actions itselves. All reference v3 in their docs. But apparently those docs are outdated, too. 🙈 |
Before this commit, we got the error message in our builds: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/login-action@65b78e6, docker/metadata-action@9ec57ed, docker/build-push-action@f2a1d5e. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ``` Apparently, even the GitHub Docs itself are outdated for the last 5 months. After visiting all the action's versions, I've pinned it to the freshest versions.
Before this commit, we got the error message in our builds: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/login-action@65b78e6, docker/metadata-action@9ec57ed, docker/build-push-action@f2a1d5e. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ``` Apparently, even the GitHub Docs itself are outdated for the last 5 months. After visiting all the action's versions, I've pinned it to the freshest versions.
So, it seems like the images can be built now on GitHub Actions, also by yourselves. Additionally, when updating the files here, there is no need to do manual rebuilds. |
Ahh, it seems like the package is still not visible. I cannot pull it:
Found a hint in the package's settings: But I'm not allowed to change it: EDIT: It's in the Org's settings |
Just found in this repository the old Docker Hub Hooks, removed them. |
Oh, this wasn't the brightest action by myself today: I already killed the docker hub dunst organisation. (the old CI cannot run anymore from now, sorry) |
good work, I have no clue how to manage docker 😢 |
@bynect we have new images already running on the CI since a while. Can we close this one? |
Sure |
Right now I get a deprecation messages from every action
So we may want to update the images. However I am not an expert in docker (I wrote the last Dockerfile 4/5 years ago) so I am not sure what to do (without breaking anything).
The text was updated successfully, but these errors were encountered: