Additional logging & handling logging during tests #368
Comments
tsipinakis
added a commit
that referenced
this issue
Oct 7, 2017
As mentioned in #368 testing for invalid values with the current implementation would result in misleading error messages being printed to stdout. These tests should be disabled until a solution is found.
By accident, I found the glib logging functions. See: https://developer.gnome.org/glib/stable/glib-Message-Logging.html
|
dj95
added a commit
to dj95/dunst
that referenced
this issue
Oct 29, 2017
commit 400c3e9 Merge: 85eb175 ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:18:59 2017 +0100 Merge branch 'feature/round_corners' of github.com:dj95/dunst into feature/round_corners commit 85eb175 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants commit ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:14:53 2017 +0100 Fixed: added degrees to constants commit d81f7ba Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:04:31 2017 +0100 Fixed: changed value to mulitplication for readability commit ce80804 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:00:56 2017 +0100 Fixed: added blank line commit 22fd21b Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:59:45 2017 +0100 Fixed: removed some style changes; moved round corners to draw commit c67cce1 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:16:36 2017 +0100 Fixed: corner radius sanitized to max half of notification height commit dc10dce Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius commit ede2e62 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 13:08:57 2017 +0100 Fixed: minor style improvements; max diameter; corner name in config commit 255ef09 Merge: ca8bc0f 11afe28 Author: Daniel Jankowski <Daniel.Jankowski@rub.de> Date: Sun Oct 29 12:48:29 2017 +0100 Merge pull request #1 from dunst-project/master Merge: upstream fixes commit 11afe28 Merge: 177fc30 75ba00f Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 27 22:40:08 2017 +0300 Merge pull request dunst-project#421 from bebehei/dbus-leakings Unref GVariants after use again commit 75ba00f Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 27 20:39:18 2017 +0200 Add changelog entry for dbus memleaks commit df56528 Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 22:12:31 2017 +0200 Unref GVariants after use again commit ca8bc0f Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 16:56:16 2017 +0200 Added: ShapeNotifyMask; Man-Page documenatation commit 9be0032 Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 15:44:55 2017 +0200 Fixed: frame behaviour on round corners commit 84524ec Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 14:43:03 2017 +0200 Fixed: minor style changes commit 2cd071d Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 12:25:12 2017 +0200 Added: support for round corners commit 177fc30 Merge: a257556 b5a48ea Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 26 18:49:49 2017 +0300 Merge pull request dunst-project#417 from bebehei/buildstack Buildstack commit b5a48ea Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 17:21:33 2017 +0200 Sync phony targets with .PHONY and organise in sections commit d07bdac Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 04:03:43 2017 +0200 Introduce debug target commit a257556 Merge: 3691b7e e3528ef Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Tue Oct 24 06:03:58 2017 +0300 Merge pull request dunst-project#418 from bebehei/microopt Microopt commit e3528ef Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 12:41:09 2017 +0200 Indent functions to standard commit 2d67a5c Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 00:15:52 2017 +0200 Remove unused ERR macro commit 2d7dc6f Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 11 16:55:28 2017 +0200 Make startup notification timeout in 10 seconds commit bfc8b17 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:55:19 2017 +0200 Reorganise CLFAGS/LDFLAGS handling commit 1091a97 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:56 2017 +0200 travis: also build dunstify commit e890052 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:19 2017 +0200 Restructure the Makefile (refactor) commit 37d76ab Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:06:40 2017 +0200 Simplify dunstify flags commit 1cb60e0 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 02:53:13 2017 +0200 Treat warnings in travis as fatal commit 3691b7e Merge: 7da60b9 3fc27e4 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 21 20:25:36 2017 +0300 Merge pull request dunst-project#371 from bebehei/configh Improve usage of config.h commit 7da60b9 Merge: d06c471 0b9dda2 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 20 20:34:08 2017 +0300 Merge pull request dunst-project#409 from bebehei/issue-template Add issue template commit d06c471 Merge: bc9ddff ca996c9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 19 05:20:39 2017 +0300 Merge pull request dunst-project#416 from bebehei/unref-notify Free notification before closing commit ca996c9 Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 18 23:45:15 2017 +0200 Free notification before closing The notification object should actually get freed by notify_uninit. But before freeing the notification, notify_uninit also sends the CloseNotification signal directly, if the timeout is 0. But the timeout of 0 should actually indicate a notification, which never expires. Fixes dunst-project#415 commit 3fc27e4 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 16 20:25:44 2017 +0200 Deprecate STATIC_CONFIG commit bc9ddff Merge: 4d59e3a 5f87039 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Wed Oct 11 17:29:15 2017 +0300 Merge pull request dunst-project#410 from EdwardBetts/patch-1 correct spelling mistake commit 0119758 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 18:09:44 2017 +0200 Do not extra check g_free for null commit 5f87039 Author: Edward Betts <edward@4angle.com> Date: Tue Oct 10 23:41:08 2017 +0100 correct spelling mistake commit bc3c646 Author: Benedikt Heine <bebe@bebehei.de> Date: Tue Oct 10 23:11:52 2017 +0200 Remove LENGTH macro and replace with glib one commit 0b9dda2 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 9 15:32:35 2017 +0200 Add issue template commit 4d59e3a Merge: e8e4af9 be3636c Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sun Oct 8 16:28:36 2017 +0300 Merge pull request dunst-project#407 from bebehei/gnu-source Remove _GNU_SOURCE macro commit be3636c Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 02:15:19 2017 +0200 Remove _GNU_SOURCE macro After some research, the _GNU_SOURCE does not affect any function call anymore. To avoid future failures on other systems not using glibc, _GNU_SOURCE gets removed. commit 20414cc Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Sep 25 22:32:06 2017 +0200 Remove config.def.h and only use config.h commit 7965fd3 Author: Benedikt Heine <bebe@bebehei.de> Date: Sat Oct 7 18:16:45 2017 +0200 Move default values into separate settings struct commit c711b59 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Sep 10 17:41:17 2017 +0200 Arrange default rules vertically commit e8e4af9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 7 19:05:49 2017 +0300 Temporarily remove invalid value test in string_to_time As mentioned in dunst-project#368 testing for invalid values with the current implementation would result in misleading error messages being printed to stdout. These tests should be disabled until a solution is found.
dj95
added a commit
to dj95/dunst
that referenced
this issue
Oct 29, 2017
commit 400c3e9 Merge: 85eb175 ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:18:59 2017 +0100 Merge branch 'feature/round_corners' of github.com:dj95/dunst into feature/round_corners commit 85eb175 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants commit ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:14:53 2017 +0100 Fixed: added degrees to constants commit d81f7ba Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:04:31 2017 +0100 Fixed: changed value to mulitplication for readability commit ce80804 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:00:56 2017 +0100 Fixed: added blank line commit 22fd21b Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:59:45 2017 +0100 Fixed: removed some style changes; moved round corners to draw commit c67cce1 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:16:36 2017 +0100 Fixed: corner radius sanitized to max half of notification height commit dc10dce Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius commit ede2e62 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 13:08:57 2017 +0100 Fixed: minor style improvements; max diameter; corner name in config commit 255ef09 Merge: ca8bc0f 11afe28 Author: Daniel Jankowski <Daniel.Jankowski@rub.de> Date: Sun Oct 29 12:48:29 2017 +0100 Merge pull request #1 from dunst-project/master Merge: upstream fixes commit 11afe28 Merge: 177fc30 75ba00f Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 27 22:40:08 2017 +0300 Merge pull request dunst-project#421 from bebehei/dbus-leakings Unref GVariants after use again commit 75ba00f Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 27 20:39:18 2017 +0200 Add changelog entry for dbus memleaks commit df56528 Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 22:12:31 2017 +0200 Unref GVariants after use again commit ca8bc0f Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 16:56:16 2017 +0200 Added: ShapeNotifyMask; Man-Page documenatation commit 9be0032 Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 15:44:55 2017 +0200 Fixed: frame behaviour on round corners commit 84524ec Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 14:43:03 2017 +0200 Fixed: minor style changes commit 2cd071d Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 12:25:12 2017 +0200 Added: support for round corners commit 177fc30 Merge: a257556 b5a48ea Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 26 18:49:49 2017 +0300 Merge pull request dunst-project#417 from bebehei/buildstack Buildstack commit b5a48ea Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 17:21:33 2017 +0200 Sync phony targets with .PHONY and organise in sections commit d07bdac Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 04:03:43 2017 +0200 Introduce debug target commit a257556 Merge: 3691b7e e3528ef Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Tue Oct 24 06:03:58 2017 +0300 Merge pull request dunst-project#418 from bebehei/microopt Microopt commit e3528ef Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 12:41:09 2017 +0200 Indent functions to standard commit 2d67a5c Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 00:15:52 2017 +0200 Remove unused ERR macro commit 2d7dc6f Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 11 16:55:28 2017 +0200 Make startup notification timeout in 10 seconds commit bfc8b17 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:55:19 2017 +0200 Reorganise CLFAGS/LDFLAGS handling commit 1091a97 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:56 2017 +0200 travis: also build dunstify commit e890052 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:19 2017 +0200 Restructure the Makefile (refactor) commit 37d76ab Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:06:40 2017 +0200 Simplify dunstify flags commit 1cb60e0 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 02:53:13 2017 +0200 Treat warnings in travis as fatal commit 3691b7e Merge: 7da60b9 3fc27e4 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 21 20:25:36 2017 +0300 Merge pull request dunst-project#371 from bebehei/configh Improve usage of config.h commit 7da60b9 Merge: d06c471 0b9dda2 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 20 20:34:08 2017 +0300 Merge pull request dunst-project#409 from bebehei/issue-template Add issue template commit d06c471 Merge: bc9ddff ca996c9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 19 05:20:39 2017 +0300 Merge pull request dunst-project#416 from bebehei/unref-notify Free notification before closing commit ca996c9 Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 18 23:45:15 2017 +0200 Free notification before closing The notification object should actually get freed by notify_uninit. But before freeing the notification, notify_uninit also sends the CloseNotification signal directly, if the timeout is 0. But the timeout of 0 should actually indicate a notification, which never expires. Fixes dunst-project#415 commit 3fc27e4 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 16 20:25:44 2017 +0200 Deprecate STATIC_CONFIG commit bc9ddff Merge: 4d59e3a 5f87039 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Wed Oct 11 17:29:15 2017 +0300 Merge pull request dunst-project#410 from EdwardBetts/patch-1 correct spelling mistake commit 0119758 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 18:09:44 2017 +0200 Do not extra check g_free for null commit 5f87039 Author: Edward Betts <edward@4angle.com> Date: Tue Oct 10 23:41:08 2017 +0100 correct spelling mistake commit bc3c646 Author: Benedikt Heine <bebe@bebehei.de> Date: Tue Oct 10 23:11:52 2017 +0200 Remove LENGTH macro and replace with glib one commit 0b9dda2 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 9 15:32:35 2017 +0200 Add issue template commit 4d59e3a Merge: e8e4af9 be3636c Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sun Oct 8 16:28:36 2017 +0300 Merge pull request dunst-project#407 from bebehei/gnu-source Remove _GNU_SOURCE macro commit be3636c Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 02:15:19 2017 +0200 Remove _GNU_SOURCE macro After some research, the _GNU_SOURCE does not affect any function call anymore. To avoid future failures on other systems not using glibc, _GNU_SOURCE gets removed. commit 20414cc Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Sep 25 22:32:06 2017 +0200 Remove config.def.h and only use config.h commit 7965fd3 Author: Benedikt Heine <bebe@bebehei.de> Date: Sat Oct 7 18:16:45 2017 +0200 Move default values into separate settings struct commit c711b59 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Sep 10 17:41:17 2017 +0200 Arrange default rules vertically commit e8e4af9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 7 19:05:49 2017 +0300 Temporarily remove invalid value test in string_to_time As mentioned in dunst-project#368 testing for invalid values with the current implementation would result in misleading error messages being printed to stdout. These tests should be disabled until a solution is found. Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants
dj95
added a commit
to dj95/dunst
that referenced
this issue
Oct 29, 2017
Fixed: frame behaviour on round corners Added: ShapeNotifyMask; Man-Page documenatation Unref GVariants after use again Add changelog entry for dbus memleaks Fixed: minor style improvements; max diameter; corner name in config Squashed commit of the following: commit 400c3e9 Merge: 85eb175 ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:18:59 2017 +0100 Merge branch 'feature/round_corners' of github.com:dj95/dunst into feature/round_corners commit 85eb175 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants commit ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:14:53 2017 +0100 Fixed: added degrees to constants commit d81f7ba Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:04:31 2017 +0100 Fixed: changed value to mulitplication for readability commit ce80804 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:00:56 2017 +0100 Fixed: added blank line commit 22fd21b Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:59:45 2017 +0100 Fixed: removed some style changes; moved round corners to draw commit c67cce1 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:16:36 2017 +0100 Fixed: corner radius sanitized to max half of notification height commit dc10dce Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius commit ede2e62 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 13:08:57 2017 +0100 Fixed: minor style improvements; max diameter; corner name in config commit 255ef09 Merge: ca8bc0f 11afe28 Author: Daniel Jankowski <Daniel.Jankowski@rub.de> Date: Sun Oct 29 12:48:29 2017 +0100 Merge pull request #1 from dunst-project/master Merge: upstream fixes commit 11afe28 Merge: 177fc30 75ba00f Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 27 22:40:08 2017 +0300 Merge pull request dunst-project#421 from bebehei/dbus-leakings Unref GVariants after use again commit 75ba00f Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 27 20:39:18 2017 +0200 Add changelog entry for dbus memleaks commit df56528 Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 22:12:31 2017 +0200 Unref GVariants after use again commit ca8bc0f Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 16:56:16 2017 +0200 Added: ShapeNotifyMask; Man-Page documenatation commit 9be0032 Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 15:44:55 2017 +0200 Fixed: frame behaviour on round corners commit 84524ec Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 14:43:03 2017 +0200 Fixed: minor style changes commit 2cd071d Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 12:25:12 2017 +0200 Added: support for round corners commit 177fc30 Merge: a257556 b5a48ea Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 26 18:49:49 2017 +0300 Merge pull request dunst-project#417 from bebehei/buildstack Buildstack commit b5a48ea Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 17:21:33 2017 +0200 Sync phony targets with .PHONY and organise in sections commit d07bdac Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 04:03:43 2017 +0200 Introduce debug target commit a257556 Merge: 3691b7e e3528ef Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Tue Oct 24 06:03:58 2017 +0300 Merge pull request dunst-project#418 from bebehei/microopt Microopt commit e3528ef Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 12:41:09 2017 +0200 Indent functions to standard commit 2d67a5c Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 00:15:52 2017 +0200 Remove unused ERR macro commit 2d7dc6f Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 11 16:55:28 2017 +0200 Make startup notification timeout in 10 seconds commit bfc8b17 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:55:19 2017 +0200 Reorganise CLFAGS/LDFLAGS handling commit 1091a97 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:56 2017 +0200 travis: also build dunstify commit e890052 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:19 2017 +0200 Restructure the Makefile (refactor) commit 37d76ab Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:06:40 2017 +0200 Simplify dunstify flags commit 1cb60e0 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 02:53:13 2017 +0200 Treat warnings in travis as fatal commit 3691b7e Merge: 7da60b9 3fc27e4 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 21 20:25:36 2017 +0300 Merge pull request dunst-project#371 from bebehei/configh Improve usage of config.h commit 7da60b9 Merge: d06c471 0b9dda2 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 20 20:34:08 2017 +0300 Merge pull request dunst-project#409 from bebehei/issue-template Add issue template commit d06c471 Merge: bc9ddff ca996c9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 19 05:20:39 2017 +0300 Merge pull request dunst-project#416 from bebehei/unref-notify Free notification before closing commit ca996c9 Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 18 23:45:15 2017 +0200 Free notification before closing The notification object should actually get freed by notify_uninit. But before freeing the notification, notify_uninit also sends the CloseNotification signal directly, if the timeout is 0. But the timeout of 0 should actually indicate a notification, which never expires. Fixes dunst-project#415 commit 3fc27e4 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 16 20:25:44 2017 +0200 Deprecate STATIC_CONFIG commit bc9ddff Merge: 4d59e3a 5f87039 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Wed Oct 11 17:29:15 2017 +0300 Merge pull request dunst-project#410 from EdwardBetts/patch-1 correct spelling mistake commit 0119758 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 18:09:44 2017 +0200 Do not extra check g_free for null commit 5f87039 Author: Edward Betts <edward@4angle.com> Date: Tue Oct 10 23:41:08 2017 +0100 correct spelling mistake commit bc3c646 Author: Benedikt Heine <bebe@bebehei.de> Date: Tue Oct 10 23:11:52 2017 +0200 Remove LENGTH macro and replace with glib one commit 0b9dda2 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 9 15:32:35 2017 +0200 Add issue template commit 4d59e3a Merge: e8e4af9 be3636c Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sun Oct 8 16:28:36 2017 +0300 Merge pull request dunst-project#407 from bebehei/gnu-source Remove _GNU_SOURCE macro commit be3636c Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 02:15:19 2017 +0200 Remove _GNU_SOURCE macro After some research, the _GNU_SOURCE does not affect any function call anymore. To avoid future failures on other systems not using glibc, _GNU_SOURCE gets removed. commit 20414cc Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Sep 25 22:32:06 2017 +0200 Remove config.def.h and only use config.h commit 7965fd3 Author: Benedikt Heine <bebe@bebehei.de> Date: Sat Oct 7 18:16:45 2017 +0200 Move default values into separate settings struct commit c711b59 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Sep 10 17:41:17 2017 +0200 Arrange default rules vertically commit e8e4af9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 7 19:05:49 2017 +0300 Temporarily remove invalid value test in string_to_time As mentioned in dunst-project#368 testing for invalid values with the current implementation would result in misleading error messages being printed to stdout. These tests should be disabled until a solution is found. Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants Fixed: removed rgba Fixed: one parameter per line Fixed: from macro to constant
dj95
added a commit
to dj95/dunst
that referenced
this issue
Oct 29, 2017
Fixed: minor style changes Fixed: frame behaviour on round corners Added: ShapeNotifyMask; Man-Page documenatation Unref GVariants after use again Add changelog entry for dbus memleaks Fixed: minor style improvements; max diameter; corner name in config Squashed commit of the following: commit 400c3e9 Merge: 85eb175 ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:18:59 2017 +0100 Merge branch 'feature/round_corners' of github.com:dj95/dunst into feature/round_corners commit 85eb175 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants commit ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:14:53 2017 +0100 Fixed: added degrees to constants commit d81f7ba Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:04:31 2017 +0100 Fixed: changed value to mulitplication for readability commit ce80804 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:00:56 2017 +0100 Fixed: added blank line commit 22fd21b Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:59:45 2017 +0100 Fixed: removed some style changes; moved round corners to draw commit c67cce1 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:16:36 2017 +0100 Fixed: corner radius sanitized to max half of notification height commit dc10dce Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius commit ede2e62 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 13:08:57 2017 +0100 Fixed: minor style improvements; max diameter; corner name in config commit 255ef09 Merge: ca8bc0f 11afe28 Author: Daniel Jankowski <Daniel.Jankowski@rub.de> Date: Sun Oct 29 12:48:29 2017 +0100 Merge pull request #1 from dunst-project/master Merge: upstream fixes commit 11afe28 Merge: 177fc30 75ba00f Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 27 22:40:08 2017 +0300 Merge pull request dunst-project#421 from bebehei/dbus-leakings Unref GVariants after use again commit 75ba00f Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 27 20:39:18 2017 +0200 Add changelog entry for dbus memleaks commit df56528 Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 22:12:31 2017 +0200 Unref GVariants after use again commit ca8bc0f Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 16:56:16 2017 +0200 Added: ShapeNotifyMask; Man-Page documenatation commit 9be0032 Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 15:44:55 2017 +0200 Fixed: frame behaviour on round corners commit 84524ec Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 14:43:03 2017 +0200 Fixed: minor style changes commit 2cd071d Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 12:25:12 2017 +0200 Added: support for round corners commit 177fc30 Merge: a257556 b5a48ea Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 26 18:49:49 2017 +0300 Merge pull request dunst-project#417 from bebehei/buildstack Buildstack commit b5a48ea Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 17:21:33 2017 +0200 Sync phony targets with .PHONY and organise in sections commit d07bdac Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 04:03:43 2017 +0200 Introduce debug target commit a257556 Merge: 3691b7e e3528ef Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Tue Oct 24 06:03:58 2017 +0300 Merge pull request dunst-project#418 from bebehei/microopt Microopt commit e3528ef Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 12:41:09 2017 +0200 Indent functions to standard commit 2d67a5c Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 00:15:52 2017 +0200 Remove unused ERR macro commit 2d7dc6f Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 11 16:55:28 2017 +0200 Make startup notification timeout in 10 seconds commit bfc8b17 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:55:19 2017 +0200 Reorganise CLFAGS/LDFLAGS handling commit 1091a97 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:56 2017 +0200 travis: also build dunstify commit e890052 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:19 2017 +0200 Restructure the Makefile (refactor) commit 37d76ab Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:06:40 2017 +0200 Simplify dunstify flags commit 1cb60e0 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 02:53:13 2017 +0200 Treat warnings in travis as fatal commit 3691b7e Merge: 7da60b9 3fc27e4 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 21 20:25:36 2017 +0300 Merge pull request dunst-project#371 from bebehei/configh Improve usage of config.h commit 7da60b9 Merge: d06c471 0b9dda2 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 20 20:34:08 2017 +0300 Merge pull request dunst-project#409 from bebehei/issue-template Add issue template commit d06c471 Merge: bc9ddff ca996c9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 19 05:20:39 2017 +0300 Merge pull request dunst-project#416 from bebehei/unref-notify Free notification before closing commit ca996c9 Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 18 23:45:15 2017 +0200 Free notification before closing The notification object should actually get freed by notify_uninit. But before freeing the notification, notify_uninit also sends the CloseNotification signal directly, if the timeout is 0. But the timeout of 0 should actually indicate a notification, which never expires. Fixes dunst-project#415 commit 3fc27e4 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 16 20:25:44 2017 +0200 Deprecate STATIC_CONFIG commit bc9ddff Merge: 4d59e3a 5f87039 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Wed Oct 11 17:29:15 2017 +0300 Merge pull request dunst-project#410 from EdwardBetts/patch-1 correct spelling mistake commit 0119758 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 18:09:44 2017 +0200 Do not extra check g_free for null commit 5f87039 Author: Edward Betts <edward@4angle.com> Date: Tue Oct 10 23:41:08 2017 +0100 correct spelling mistake commit bc3c646 Author: Benedikt Heine <bebe@bebehei.de> Date: Tue Oct 10 23:11:52 2017 +0200 Remove LENGTH macro and replace with glib one commit 0b9dda2 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 9 15:32:35 2017 +0200 Add issue template commit 4d59e3a Merge: e8e4af9 be3636c Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sun Oct 8 16:28:36 2017 +0300 Merge pull request dunst-project#407 from bebehei/gnu-source Remove _GNU_SOURCE macro commit be3636c Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 02:15:19 2017 +0200 Remove _GNU_SOURCE macro After some research, the _GNU_SOURCE does not affect any function call anymore. To avoid future failures on other systems not using glibc, _GNU_SOURCE gets removed. commit 20414cc Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Sep 25 22:32:06 2017 +0200 Remove config.def.h and only use config.h commit 7965fd3 Author: Benedikt Heine <bebe@bebehei.de> Date: Sat Oct 7 18:16:45 2017 +0200 Move default values into separate settings struct commit c711b59 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Sep 10 17:41:17 2017 +0200 Arrange default rules vertically commit e8e4af9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 7 19:05:49 2017 +0300 Temporarily remove invalid value test in string_to_time As mentioned in dunst-project#368 testing for invalid values with the current implementation would result in misleading error messages being printed to stdout. These tests should be disabled until a solution is found. Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants Fixed: removed rgba Fixed: one parameter per line Fixed: from macro to constant
dj95
added a commit
to dj95/dunst
that referenced
this issue
Nov 1, 2017
Fixed: minor style changes Fixed: frame behaviour on round corners Added: ShapeNotifyMask; Man-Page documenatation Unref GVariants after use again Add changelog entry for dbus memleaks Fixed: minor style improvements; max diameter; corner name in config Squashed commit of the following: commit 400c3e9 Merge: 85eb175 ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:18:59 2017 +0100 Merge branch 'feature/round_corners' of github.com:dj95/dunst into feature/round_corners commit 85eb175 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants commit ca20b8d Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 21:14:53 2017 +0100 Fixed: added degrees to constants commit d81f7ba Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:04:31 2017 +0100 Fixed: changed value to mulitplication for readability commit ce80804 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 20:00:56 2017 +0100 Fixed: added blank line commit 22fd21b Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:59:45 2017 +0100 Fixed: removed some style changes; moved round corners to draw commit c67cce1 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 19:16:36 2017 +0100 Fixed: corner radius sanitized to max half of notification height commit dc10dce Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 14:55:10 2017 +0100 Fixed: corner frame and side frame now match at large radius commit ede2e62 Author: dj95 <Daniel.Jankowski@rub.de> Date: Sun Oct 29 13:08:57 2017 +0100 Fixed: minor style improvements; max diameter; corner name in config commit 255ef09 Merge: ca8bc0f 11afe28 Author: Daniel Jankowski <Daniel.Jankowski@rub.de> Date: Sun Oct 29 12:48:29 2017 +0100 Merge pull request #1 from dunst-project/master Merge: upstream fixes commit 11afe28 Merge: 177fc30 75ba00f Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 27 22:40:08 2017 +0300 Merge pull request dunst-project#421 from bebehei/dbus-leakings Unref GVariants after use again commit 75ba00f Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 27 20:39:18 2017 +0200 Add changelog entry for dbus memleaks commit df56528 Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 22:12:31 2017 +0200 Unref GVariants after use again commit ca8bc0f Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 16:56:16 2017 +0200 Added: ShapeNotifyMask; Man-Page documenatation commit 9be0032 Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 15:44:55 2017 +0200 Fixed: frame behaviour on round corners commit 84524ec Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 14:43:03 2017 +0200 Fixed: minor style changes commit 2cd071d Author: dj95 <Daniel.Jankowski@rub.de> Date: Fri Oct 27 12:25:12 2017 +0200 Added: support for round corners commit 177fc30 Merge: a257556 b5a48ea Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 26 18:49:49 2017 +0300 Merge pull request dunst-project#417 from bebehei/buildstack Buildstack commit b5a48ea Author: Benedikt Heine <bebe@bebehei.de> Date: Thu Oct 26 17:21:33 2017 +0200 Sync phony targets with .PHONY and organise in sections commit d07bdac Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 04:03:43 2017 +0200 Introduce debug target commit a257556 Merge: 3691b7e e3528ef Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Tue Oct 24 06:03:58 2017 +0300 Merge pull request dunst-project#418 from bebehei/microopt Microopt commit e3528ef Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 12:41:09 2017 +0200 Indent functions to standard commit 2d67a5c Author: Benedikt Heine <bebe@bebehei.de> Date: Fri Oct 13 00:15:52 2017 +0200 Remove unused ERR macro commit 2d7dc6f Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 11 16:55:28 2017 +0200 Make startup notification timeout in 10 seconds commit bfc8b17 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:55:19 2017 +0200 Reorganise CLFAGS/LDFLAGS handling commit 1091a97 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:56 2017 +0200 travis: also build dunstify commit e890052 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:11:19 2017 +0200 Restructure the Makefile (refactor) commit 37d76ab Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 03:06:40 2017 +0200 Simplify dunstify flags commit 1cb60e0 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 22 02:53:13 2017 +0200 Treat warnings in travis as fatal commit 3691b7e Merge: 7da60b9 3fc27e4 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 21 20:25:36 2017 +0300 Merge pull request dunst-project#371 from bebehei/configh Improve usage of config.h commit 7da60b9 Merge: d06c471 0b9dda2 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Fri Oct 20 20:34:08 2017 +0300 Merge pull request dunst-project#409 from bebehei/issue-template Add issue template commit d06c471 Merge: bc9ddff ca996c9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Thu Oct 19 05:20:39 2017 +0300 Merge pull request dunst-project#416 from bebehei/unref-notify Free notification before closing commit ca996c9 Author: Benedikt Heine <bebe@bebehei.de> Date: Wed Oct 18 23:45:15 2017 +0200 Free notification before closing The notification object should actually get freed by notify_uninit. But before freeing the notification, notify_uninit also sends the CloseNotification signal directly, if the timeout is 0. But the timeout of 0 should actually indicate a notification, which never expires. Fixes dunst-project#415 commit 3fc27e4 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 16 20:25:44 2017 +0200 Deprecate STATIC_CONFIG commit bc9ddff Merge: 4d59e3a 5f87039 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Wed Oct 11 17:29:15 2017 +0300 Merge pull request dunst-project#410 from EdwardBetts/patch-1 correct spelling mistake commit 0119758 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 18:09:44 2017 +0200 Do not extra check g_free for null commit 5f87039 Author: Edward Betts <edward@4angle.com> Date: Tue Oct 10 23:41:08 2017 +0100 correct spelling mistake commit bc3c646 Author: Benedikt Heine <bebe@bebehei.de> Date: Tue Oct 10 23:11:52 2017 +0200 Remove LENGTH macro and replace with glib one commit 0b9dda2 Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Oct 9 15:32:35 2017 +0200 Add issue template commit 4d59e3a Merge: e8e4af9 be3636c Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sun Oct 8 16:28:36 2017 +0300 Merge pull request dunst-project#407 from bebehei/gnu-source Remove _GNU_SOURCE macro commit be3636c Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Oct 8 02:15:19 2017 +0200 Remove _GNU_SOURCE macro After some research, the _GNU_SOURCE does not affect any function call anymore. To avoid future failures on other systems not using glibc, _GNU_SOURCE gets removed. commit 20414cc Author: Benedikt Heine <bebe@bebehei.de> Date: Mon Sep 25 22:32:06 2017 +0200 Remove config.def.h and only use config.h commit 7965fd3 Author: Benedikt Heine <bebe@bebehei.de> Date: Sat Oct 7 18:16:45 2017 +0200 Move default values into separate settings struct commit c711b59 Author: Benedikt Heine <bebe@bebehei.de> Date: Sun Sep 10 17:41:17 2017 +0200 Arrange default rules vertically commit e8e4af9 Author: Nikos Tsipinakis <nikos@tsipinakis.com> Date: Sat Oct 7 19:05:49 2017 +0300 Temporarily remove invalid value test in string_to_time As mentioned in dunst-project#368 testing for invalid values with the current implementation would result in misleading error messages being printed to stdout. These tests should be disabled until a solution is found. Fixed: corner frame and side frame now match at large radius Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants Fixed: corner radius sanitized to max half of notification height Fixed: removed some style changes; moved round corners to draw Fixed: added blank line Fixed: changed value to mulitplication for readability Fixed: added degrees to constants Fixed: removed rgba Fixed: one parameter per line Fixed: from macro to constant Fixed: indentation and degree constant
|
As #428 has to test for faulty values, I've sat down on this again. I'm working currently on this at my logging branch.
The decision to specify, which external logging API we should use, is actually quite easy. The GLib logging methods work easy, fully suffice the needs and do not increase our footprint. To not make the race, there has to be another framework, which is exceptionally good. But there isn't. All other frameworks have their specialities. GLib does simple general Purpose logging. That's what we need. Alternatively, we could assemble our own small header files, which do not have to be big to be powerful.
I also miss some some calls by default in dunst. When debugging some issues, I mostly have to write all my logging calls from scratch. But in relation to this PR, I wouldn't make this a goal of it. I think it's more effective to introduce logging calls when you really need them. I think we should give here a rough guideline, when it's neccessary/ok to introduce new calls with new code.
Unit testing has its purpose to feed the program with faulty input. And the program spits out warning, when fed with faulty input. Our tests should not cover the warnings. These should check, that the returnvalues are still sanitized. Their purpose is not to check for warnings. Anyways, when we're feeding the program with faulty input, it's expected to print warnings. So when testing with enabled logging, you have to go through every message manually. I would also add another point: Logging guidlines I would in general add some logging guidlines written down (maybe in Contributing.md or somewhere else), which are covering the following questions.
|
|
I'm finished with it. Actually I'd like to give it into review now and get feedback. But i'd like to get #428 at least approved first. |
|
We may want to use structured logging, too. This is really neat in combination with systemd. https://www.youtube.com/watch?v=I_elueI6JY0 |
Closed
|
Idea: print the notification as log message with structured logging enabled. Then with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've wanted for a while to look into adding more detailed logging into dunst. Currently we have
fprintfstatements scattered around the codebase which makes the logging behaviour hard to control.We should look into implement a more centralised logging solution that can be set to multiple levels from
error,warnwhich are the messages we display now but it should also be able to be set todebugwhich would print step-by-step info on what dunst is doing to make debugging a bit easier.A rough tasklist for that is as follows (will be expanded as needed):
I was prompted to create this issue while reviewing #365 in which a bug was encountered in the handling of an error condition which creates a problem with the current logging system since we can't implement a regression test without having errors in the test report.
The main question for now is: How we should distinguish expected and unexpected errors during testing? We can obviously simply disable them altogether but that would also disable logging unexpected errors that we DO want to be notified for.
The text was updated successfully, but these errors were encountered: