Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme fixes and appname toggle #1

Closed
wants to merge 3 commits into from

Conversation

scottjad
Copy link

Very cool app!

I fixed a couple mistakes in README and added a toggle for the appname. The problem is 99% of the time, for me at least, it shows notify-send which isn't very interesting.

I don't know C so sorry if there are mistakes. Wasn't sure about option convention including naming (-appname or --disable-appname or --appname=x), or how to write options (0/1). Feel free to change.

Probably the only thing I'm missing with this is icons. If you stick with all text might still be nice to allow displaying the name of the icon. With notify-send I use -i info and -i alert and -i appname a lot. Maybe display it with the same syntax as appname currently.

@knopwob
Copy link
Member

knopwob commented Sep 15, 2011

First of all thank you very much for your interest.
I generate the README from dunst.1 (the man page for dunst), so any changes to the README should actually go there. I'll fix those errors in the next batch of commits, so there's no need for you to create another commit for them.
About toggling displaying of the appname: Your code looks fine, but I've already planned a -format option which will work something like this:

dunst -format "%a: %s -- %b"

%a will then be replaced with the appname, %s with the message summary and %b with the messge body. (this example is the format currently used). So if you don't want the appname to not be displayed, you will be able to change the format to

dunst -format "%s: %b"

Maybe I'll add support for Icons in the future, but currently it's a very low priority for me. But once the -format option is implemented, I can add %i for the icon name.
I'm very sorry that I can't pull this, but I hope you understand that the -appname option will be superseded soon.

@knopwob knopwob closed this Sep 15, 2011
@scottjad
Copy link
Author

Sounds great

@scottjad
Copy link
Author

I agree icons don't make much since with the height of the typical message, but what actually would be cool I think would be to allow defining different fg/bg combos based on the icon name. So I could define a default color scheme and then have special ones for -i alert and -i info.

@knopwob
Copy link
Member

knopwob commented Sep 15, 2011

One thing I'm currently working on is to make dunst obay the urgency-level of the message. The specifications for notifications allow three levels: low,normal and critical. If this is finished, you will be able to define a colorscheme for each level.
Another thing I have in mind is the ability to filter the messages for strings and change the color accordingly (a different color for different contacts in pidgin comes to mind). But this won't happen before I've implemented a config file, as this would be to much stuff for the commandline.

@scottjad
Copy link
Author

Cool if you could specify what field you wanted the filter to match (not just summary/body) that would solve my problem as long as it included supported for icon name. You could use do %a "pidgin" to give all pidgin messages a specific scheme, and then be more specific for contacts if you wanted.

jgriebler pushed a commit to jgriebler/dunst that referenced this pull request Oct 13, 2016
Fix segfault in startup notification
@ghost ghost mentioned this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants