Enable pango font fallback #1222
Conversation
|
I just noticed that my editor removed some space 😅 |
src/draw.c
Outdated
| */ | ||
| // left side (fill) | ||
| cairo_set_source_rgba(c, cl->highlight.r, cl->highlight.g, cl->highlight.b, cl->highlight.a); | ||
| draw_rounded_rect(c, x_bar_1, frame_y, progress_width_1, progress_height, | ||
| draw_rounded_rect(c, x_bar_1, frame_y, progress_width_1, progress_height, |
There was a problem hiding this comment.
Why is there a change in progress bar drawing?
There was a problem hiding this comment.
I just noticed that my editor removed some space 😅 ^^
|
Looking back at it, I am quite at loss as to why the ci failed |
It seems the test failed because of some other reason. Pushing some code should re-run the test (I cannot find the button to re-run). |
|
Does it fallback to the second font in the list or to some other font on the system? |
According to pango docs it should fallback using system font settings (so ignoring the given font list). But it seems like this works only on supported systems (fontconfig and maybe others). |
|
@bynect could you push this branch, so the CI runs again? You might need to make a small change, which you can revert afterwards. |
bynect
force-pushed
the
allow-multi-fonts
branch
from
b0e2292
to
0d9c9d5
Compare
|
@fwsmit I removed the change in the bar code and force pushed |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1222 +/- ##
==========================================
- Coverage 66.03% 65.43% -0.60%
==========================================
Files 46 46
Lines 7595 7753 +158
==========================================
+ Hits 5015 5073 +58
- Misses 2580 2680 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks! The tests pass now, so I'll go ahead an merge! |
This is a simple addition to text rendering that allows fallback fonts. This improved my experience with #1211 when using a monospace with font awesome glyphs.
However this is not a complete solution! The problem with multiple fonts is in pango design.
It allows only one font to be loaded when rendering. In this patch I simply add the pango attribute for font fallback.