Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix progress bar rounding at 0% by disabling rounding in these circumstances #1249

Closed
wants to merge 1 commit into from

Conversation

Fxzzi
Copy link

@Fxzzi Fxzzi commented Jan 2, 2024

Hello dunst-project!!

A very small PR here;

An example of the original issue:
image
You can see here with rounding enabled on the progress bar, at 0% the rounding does not render correctly (it technically renders correctly, but not in the way a user would expect)

This PR simply fixes this by making sure the progress width is not 0 before drawing the rounded sides.

Here is how it looks after:
image

rounding at all other percentage levels is identical to before as expected:
image

Let me know if any changes are required, I'll be happy to help :)

@bynect
Copy link
Member

bynect commented Jan 18, 2024

this is a duplicate of #1227, which in turn is a part of #1213

@fwsmit
Copy link
Member

fwsmit commented Jan 20, 2024

Hey, thanks for this PR. As noted above this is already fixed by #1227.

@fwsmit fwsmit closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants