-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an optional id to dunstctl close
#1351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 50 50
Lines 8209 8209
Branches 962 962
=======================================
Hits 5414 5414
Misses 2795 2795
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It would be nice to adjust the completions as well (at least the summary strings) for zsh and fish as they're misleading otherwise.
right, forgot about that 👍🏻 |
@zappolowski I fixed some typos and updated the completions. Unfortunately we can't autocomplete the id (see my suggestion in #1348). |
done. unrelated question, should we add a completion for dunstify later? |
Yes, this would make sense. I just added it for fish as that's what I'm using. |
No description provided.