-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress bar #775
Add progress bar #775
Conversation
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
==========================================
- Coverage 65.94% 65.53% -0.42%
==========================================
Files 29 29
Lines 5162 5225 +63
==========================================
+ Hits 3404 3424 +20
- Misses 1758 1801 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some code style nitpicks and you also forgot to add the new settings to the example dunstrc
.
This PR was a breeze to review and couldn't even find any breaking bugs. Huge kudos! :)
d82c8e3
to
8fa3c65
Compare
Thank you for the review. I have addressed everything. The tests are failing, because progress values greater than 100 are being changed to 100. Is there a reason why it's better not to change them to 100? |
There can be cases where the progress can be >100%, think for example volume levels with pulseaudio that can go to 150+. So it's best to handle it here so |
Good point. I have applied your suggestion |
src/settings.c
Outdated
|
||
settings.progress_bar = option_get_bool( | ||
"global", | ||
"progress_bar", "-progress_bar", false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set this to true
as well, the goal is to have this and dunstrc
in sync at some point not make it diverge more :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I forgot that one. I changed it now
Merged! Thanks for your work. |
This PR addresses #772. It add a progress bar at the bottom of the notification when a value is passed via a dbus hint. Settings have been added to turn off the progress bar. The old behaviour of showing a percentage in text can still be used the same way and even in conjunction with the progress bar.
A highlight colour is added and used for drawing the progress bar.
This is what it currently looks like
Example usage
notify-send -h int:value:10 "Brightness"