Skip to content

Commit

Permalink
Revert typing on user_handle
Browse files Browse the repository at this point in the history
  • Loading branch information
MasterKale committed Jan 8, 2024
1 parent 963ba2e commit 6c0c544
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
13 changes: 0 additions & 13 deletions tests/test_bytes_subclass_support.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,3 @@ def base64url_to_memoryview(data: str) -> memoryview:
)

assert verification.new_sign_count == 7

def test_supports_strings_for_bytes(self) -> None:
"""
Preserve the ability to pass strings for `bytes` fields
"""
response = AuthenticatorAssertionResponse(
authenticator_data=bytes(),
client_data_json=bytes(),
signature=bytes(),
user_handle="some_user_handle_string",
)

self.assertEqual(response.user_handle, "some_user_handle_string")
2 changes: 1 addition & 1 deletion webauthn/helpers/structs.py
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ class AuthenticatorAssertionResponse:
client_data_json: bytes
authenticator_data: bytes
signature: bytes
user_handle: Optional[Union[bytes, str]] = None
user_handle: Optional[bytes] = None


@dataclass
Expand Down

0 comments on commit 6c0c544

Please sign in to comment.