This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
FIDO Server conformance tests now passing 100% #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved COSE related things to their own package * move assertion to cose verify * Server-ServerPublicKeyCredentialCreationOptions-Req-1 * Update login.go * Fix packed attestation signature verification and added ServerResponse structure * Conformance testing fixes for MakeCredential * Conformance tests nearly complete * Initial metadata layout * Metadata progress * Further progress on metadata * Resolving conflict * Production and conformance metadata now load * Move SafetyNet to jwt-go and add sanity check for timestamp * Certificate checks on metadata TOC * Restrict timestamp check in safetynet to conformance only * Don't return safetynet x5c
|
|
|
seeing what could be a unicode error in the test results here, gonna pull down the branch and see what's up |
|
Great stuff |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to pass the metadata tests and a small number of non-metadata tests, you must press the "DOWNLOAD SERVER METADATA" button in the conformance client and extract the resulting archive file into the folder referenced by this line: https://github.com/duo-labs/webauthn.io/blob/2c2c93545aeec2f9ce76c66834c3de4d2ec4adda/server/fido-conformance.go#L70
If you wish to use production metadata, you must obtain an access token from https://mds2.fidoalliance.org/tokens/ and put it in the environment variable referenced by this line: https://github.com/duo-labs/webauthn.io/blob/2c2c93545aeec2f9ce76c66834c3de4d2ec4adda/server/server.go#L109
If you wish to use custom metadata, for example https://github.com/solokeys/solo/blob/master/metadata/Solo-FIDO2-CTAP2-Authenticator.json, you would store that metadata file in a folder and load It like this line: https://github.com/duo-labs/webauthn.io/blob/2c2c93545aeec2f9ce76c66834c3de4d2ec4adda/server/server.go#L158