Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #33

Merged
merged 15 commits into from
Oct 23, 2023
Merged

Conversation

mikejritter
Copy link
Contributor

Jira: ?

Changes

  • Update spring dependencies for 5 support
  • Replace wix with testcontainers for mysql testing
  • Bump easymock and hibernate dependencies
  • Set jboss-logging version to avoid dependency conflict

Notes

I had to do some configuration on my environment to get testcontainers to run properly for me because my docker ran as root only previously. This makes testing a little harder by default and adds an external dependency, but also allows use of an actual mysql db. I don't believe there should be any changes necessary for the gitlab ci to work correctly. @dbernstein let me know what you think.

There were a few small changes I had to make to the tests to get everything to work. Notably, setting the charset and collate for the mill database and removing any data saved after tests were run (I think the embedded db was being recreated on each test before).

There are also a few small api updates from the spring-data updates, I think findOne -> findById is the most significant.

@mikejritter
Copy link
Contributor Author

Something to note that I didn't catch until now:

  • The hibernate-validator version specified doesn't exist, and I'm guessing the build passes because it is isn't used anywhere
  • The latest version of 5.4.x (which is EOL) for the validator is 5.4.3
  • For this project is seems like we might want to drop it from the dependency management, then we can figure out what to do in other projects

@dbernstein
Copy link
Member

I removed the DOCKER_HOST environment variable from my environment and everything built smoothly.

I was having problems with the 5.7 mysql container starting cleanly, so I decided to try the default image testcontainers uses. This seems to have fixed my problem with the added benefit of staying in line with the version of testcontainers we're on.
@dbernstein dbernstein merged commit f87af40 into duracloud:develop Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants