-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #33
Merged
dbernstein
merged 15 commits into
duracloud:develop
from
mikejritter:dependency-updates
Oct 23, 2023
Merged
Update dependencies #33
dbernstein
merged 15 commits into
duracloud:develop
from
mikejritter:dependency-updates
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something to note that I didn't catch until now:
|
dbernstein
approved these changes
Feb 28, 2023
I removed the DOCKER_HOST environment variable from my environment and everything built smoothly. |
I was having problems with the 5.7 mysql container starting cleanly, so I decided to try the default image testcontainers uses. This seems to have fixed my problem with the added benefit of staying in line with the version of testcontainers we're on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: ?
Changes
Notes
I had to do some configuration on my environment to get testcontainers to run properly for me because my docker ran as root only previously. This makes testing a little harder by default and adds an external dependency, but also allows use of an actual mysql db. I don't believe there should be any changes necessary for the gitlab ci to work correctly. @dbernstein let me know what you think.
There were a few small changes I had to make to the tests to get everything to work. Notably, setting the charset and collate for the mill database and removing any data saved after tests were run (I think the embedded db was being recreated on each test before).
There are also a few small api updates from the spring-data updates, I think
findOne
->findById
is the most significant.