New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make some fields in struct ListBucketResult optional #267

Merged

durch merged 1 commit into durch:master from mateuszkj:master

Apr 21, 2022

Contributor

mateuszkj commented Apr 9, 2022

Describe the bug
Some S3 self-hosted servers do not returns all fields during listing files. This merge request makes that fields optional.

I run with this problem with S3 servers:

https://github.com/datenlord/s3-server (also written in Rust)
https://github.com/chrislusf/seaweedfs

I tested only ListObjectsV2 and GetObjectRange commands with above servers.

Additional context

I checked whats fields are required in aws-sdk-rus and there almost all are optional, even key.

ListObjectsV2Output - https://github.com/awslabs/aws-sdk-rust/blob/main/sdk/s3/src/output.rs#L2366=
Object - https://github.com/awslabs/aws-sdk-rust/blob/main/sdk/s3/src/model.rs#L13517=


          make some fields in struct ListBucketResult optional

20a9697

mateuszkj mentioned this pull request

Experiment with rust-s3 and caching datafusion-contrib/datafusion-objectstore-s3#53

Draft

durch merged commit 1b37a48 into durch:master

Owner

durch commented Apr 21, 2022

@mateuszkj thanks for the PR, will be released in 0.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet