Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let finalize return the hash directly and not wrapped into a Result #259

Closed
moCello opened this issue Apr 2, 2024 · 0 comments · Fixed by #262
Closed

Let finalize return the hash directly and not wrapped into a Result #259

moCello opened this issue Apr 2, 2024 · 0 comments · Fixed by #262
Labels
team:Core Low Level Core Development Team (Rust) type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@moCello
Copy link
Member

moCello commented Apr 2, 2024

Summary

Change finalize in both Hash and HashGadget to return the hash directly. We can do this since we start and finish the Safe instance in the same method and hence have direct control over the correctness of the io-pattern (which is the only way the method would error), i.e. an error is in fact not possible.
@HDauven HDauven added type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) team:Core Low Level Core Development Team (Rust) labels Apr 10, 2024
moCello added a commit that referenced this issue Apr 17, 2024
@moCello
Change finalize to return the hash directly
3004d0c 
Resolves #259
@moCello moCello mentioned this issue Apr 17, 2024
Merged
moCello added a commit that referenced this issue Apr 17, 2024
@moCello
Change finalize to return the hash directly
6f29fe0 
Resolves #259
moCello added a commit that referenced this issue Apr 17, 2024
@moCello
Change finalize to return the hash directly
ebb207e 
Resolves #259
@moCello moCello mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team:Core Low Level Core Development Team (Rust) type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change finalize to return the hash directly dusk-network/Poseidon252
2 participants
@HDauven @moCello