Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the Scalar of GENERATOR, #100

Closed
simplelins opened this issue Oct 14, 2022 · 6 comments · Fixed by #111
Closed

the Scalar of GENERATOR, #100

simplelins opened this issue Oct 14, 2022 · 6 comments · Fixed by #111
Labels
fix:bug Something isn't working

Comments

@simplelins
Copy link

in my mind, the scalar is in montgomery form. such as the ROOT_OF_UNITY Scalar([
0xb9b58d8c5f0e466a,
0x5b1b4c801819d7ec,
0x0af53ae352a31e64,
0x5bf3adda19e9b27b,
]) that is in montgomery form.

but why the GENERATOR is Scalar([7, 0, 0, 0]), it is in normal form.

@simplelins simplelins added the fix:bug Something isn't working label Oct 14, 2022
@sanderdms
Copy link

Related to dusk-network/piecrust#118 ?

@simplelins
Copy link
Author

Related to dusk-network/piecrust#118 ?

oh, no, the GENERATOR use to cosetfft and coset_ifft, the result is different from other libs for the value of GENERATOR .

moCello added a commit that referenced this issue May 19, 2023
Resolves: #100
@moCello moCello mentioned this issue May 19, 2023
moCello added a commit that referenced this issue May 19, 2023
@moCello
Copy link
Member

moCello commented May 19, 2023

You are absolutely right, we missed a from_raw in this. Luckily we don't seem to use this constant anywhere, so I removed it entirely. Thanks a lot for pointing this out!

@simplelins
Copy link
Author

You are absolutely right, we missed a from_raw in this. Luckily we don't seem to use this constant anywhere, so I removed it entirely. Thanks a lot for pointing this out!

please not remove, this constant is important for external libs.such as cosetfft and icosetfft

@moCello
Copy link
Member

moCello commented Jun 2, 2023

It will be (correctly) reintroduced with the next release as part of our effort of aligning our crate with the zkcrypto ustream #116

@simplelins
Copy link
Author

ok, thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants