Refactor and rename Scalar::from_bytes_wide
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/from_blake2b
branch
from
5c4c2c3
to
721e1ec
Compare
vlopes11
requested changes
Dec 5, 2023
moCello
force-pushed
the
mocello/from_blake2b
branch
2 times, most recently
from
ba307b3
to
a99a91b
Compare
vlopes11
approved these changes
Dec 5, 2023
moCello
force-pushed
the
mocello/from_blake2b
branch
from
a99a91b
to
d08bc2e
Compare
|
unfortunately the name |
It now used a 512-bit large destination string to hash into. New name: `hash_to_scalar`. Resolves #137 Co-authored_by: Victor Lopez <victor@dusk.network>
moCello
force-pushed
the
mocello/from_blake2b
branch
from
d08bc2e
to
c8e17a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now used a 512-bit large destination string to hash into. New name:
from_blake2bhash_to_scalar.Resolves #137