Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary expect/unwrap #115

Closed
herr-seppia opened this issue Oct 20, 2022 · 0 comments · Fixed by #116
Closed

Remove unnecessary expect/unwrap #115

herr-seppia opened this issue Oct 20, 2022 · 0 comments · Fixed by #116
Assignees
@herr-seppia
Labels
mark:testnet

Comments

@herr-seppia
Copy link
Member

Summary

The codebase is full of unwrap/expect.

Possible solution design or implementation

Those should be removed in favour of a Result approach and, if that won't fit, an expect should be used.

Additional context

N/A
@herr-seppia herr-seppia self-assigned this Oct 20, 2022
herr-seppia added a commit that referenced this issue Oct 20, 2022
@herr-seppia
Change Peer::new to return Result
aede873 
This is a larger refactor that aims to make the library more stable by removing unwrap and expect

Resolves #115
@herr-seppia herr-seppia mentioned this issue Oct 20, 2022
Merged
herr-seppia added a commit that referenced this issue Oct 21, 2022
@herr-seppia
Change Peer::new to return Result
22d9746 
This is a larger refactor that aims to make the library more stable by removing unwrap and expect

Resolves #115
@herr-seppia herr-seppia mentioned this issue May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herr-seppia herr-seppia

Labels
mark:testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unwrap/expect dusk-network/kadcast
1 participant
@herr-seppia