Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to on_message callback #59

Closed
herr-seppia opened this issue Nov 24, 2021 · 0 comments
Closed

Add metadata to on_message callback #59

herr-seppia opened this issue Nov 24, 2021 · 0 comments
Assignees
Labels
team:WebTech End to End UX / UI and blockchain

Comments

@herr-seppia
Copy link
Member

Describe what you want implemented
The on_message callback must receive metadata related to the message received:

  • Actual: on_message: fn(Vec<u8>)
  • Needed: on_message: fn(Vec<u8>, MessageInfo)

MessageInfo should contain info about the actual kadcast broadcast height and the source peer address

Describe "Why" this is needed
The source address is needed as prerequisite to enable direct communication between nodes
The kadcast broadcast height is required to handle the manual propagation

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
"Manual propagation" is issued in #57
"Direct communication" is issued in #58

@herr-seppia herr-seppia added the team:WebTech End to End UX / UI and blockchain label Nov 24, 2021
@t00ts t00ts self-assigned this Dec 3, 2021
@t00ts t00ts closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:WebTech End to End UX / UI and blockchain
Projects
None yet
Development

No branches or pull requests

2 participants