Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to on_message callback #66

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Add metadata to on_message callback #66

merged 1 commit into from
Dec 3, 2021

Conversation

t00ts
Copy link
Contributor

@t00ts t00ts commented Dec 3, 2021

Added metadata to on_message callback as per #59

Added a MessageInfo struct within encoding module because imho it made sense for it to be there with other Message, Header, Payload, and other related types.

Using a tuple for actual message passing through the notification channel.

@t00ts t00ts added the team:WebTech End to End UX / UI and blockchain label Dec 3, 2021
@t00ts t00ts requested a review from herr-seppia December 3, 2021 09:30
@t00ts t00ts self-assigned this Dec 3, 2021
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t00ts
Copy link
Contributor Author

t00ts commented Dec 3, 2021

For future reference:

Added a MessageInfo struct within encoding module because imho it made sense for it to be there with other Message, Header, Payload, and other related types.

We changed this and MessageInfo is now part of the handling module, as it's where messages are processed.

@t00ts t00ts merged commit dc3a0ff into main Dec 3, 2021
@herr-seppia herr-seppia deleted the fix-59 branch December 7, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:WebTech End to End UX / UI and blockchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants