Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the callback into a trait #63

Closed
herr-seppia opened this issue Dec 1, 2021 · 0 comments · Fixed by #64
Closed

Change the callback into a trait #63

herr-seppia opened this issue Dec 1, 2021 · 0 comments · Fixed by #64
Assignees
Labels
team:WebTech End to End UX / UI and blockchain type:tech-debt the issue is a tech debt that needs fixing

Comments

@herr-seppia
Copy link
Member

Describe what you want implemented
The on_message parameter should be a trait instead of fn(Vec<u8>)

Describe "Why" this is needed
Binding the callback to a simple function is useless in most scenarios. A trait is simply more manageable due to the self context availability

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@herr-seppia herr-seppia added team:WebTech End to End UX / UI and blockchain type:tech-debt the issue is a tech debt that needs fixing labels Dec 1, 2021
@herr-seppia herr-seppia self-assigned this Dec 1, 2021
herr-seppia added a commit that referenced this issue Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:WebTech End to End UX / UI and blockchain type:tech-debt the issue is a tech debt that needs fixing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant