Set rust toolchain version to nightly 2023-11-10 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-sonuga
force-pushed
the
fix-rust-version
branch
from
b3c73e4 to
3798ac3
Compare
d-sonuga
requested review from
miloszm,
HDauven,
xevisalle,
herr-seppia and
Neotamandua
HDauven
approved these changes
Feb 6, 2025
Neotamandua
approved these changes
Feb 6, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #96.
rust-toolchain.tomluses the latest nightly version instead of a fixed one. This PR temporarily solves the problem of the failing lint by setting the rust version to one in which the lint is absent instead of modifying the code. Updating the rust toolchain versions used across dusk crates will be done as a separate issue dusk-network/rusk#3470.As mentioned in dusk-network/safe#27, most dusk crates use a rust version nightly-2023-11-10, so that is the version chosen to be used here, too.